ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Foxworthy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-4427) Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation
Date Wed, 30 Nov 2016 03:44:58 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707418#comment-15707418
] 

Paul Foxworthy commented on OFBIZ-4427:
---------------------------------------

Hi Jacques,

I think there's no need to be scared :-). I agree with your analysis: conversionRate will
be null, so the inner if statement can be removed.

I suggest: change the else part of the inner if to throw an exception, then create a unit
test to verify the exception never happens.


> Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during
compilation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4427
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: UtilValidate.isEmpty
>         Attachments: OFBIZ-4427.patch, OFBIZ-4427_isEmpty.patch
>
>
> Hence we need to remove the UtilValidate.isEmpty(Object) method and provide methods that
accept explicit types.  
> Scripting languages should use a facade class that provides methods for working with
generic Objects or providing default behaviors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message