Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 21E70200B8C for ; Mon, 12 Sep 2016 17:33:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 20653160AD6; Mon, 12 Sep 2016 15:33:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D923160AB2 for ; Mon, 12 Sep 2016 17:33:21 +0200 (CEST) Received: (qmail 89874 invoked by uid 500); 12 Sep 2016 15:33:20 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 89863 invoked by uid 99); 12 Sep 2016 15:33:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 15:33:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 79FB92C014F for ; Mon, 12 Sep 2016 15:33:20 +0000 (UTC) Date: Mon, 12 Sep 2016 15:33:20 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Sep 2016 15:33:22 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484423#comment-15484423 ] Jacques Le Roux commented on OFBIZ-8179: ---------------------------------------- Thanks Scott and Jacopo, this is the better compromise indeed. > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component > ------------------------------------------------------------------------------------------------- > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: Jacopo Cappellato > Assignee: Jacopo Cappellato > Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8179.patch, TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and component dependencies because it removes a cyclic dependency between entity and geronimo components (see diagram attached that explain the architecture before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)