Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B728B200B83 for ; Fri, 2 Sep 2016 13:20:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B5A33160AAB; Fri, 2 Sep 2016 11:20:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D9F4160AAC for ; Fri, 2 Sep 2016 13:20:21 +0200 (CEST) Received: (qmail 74441 invoked by uid 500); 2 Sep 2016 11:20:21 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 74407 invoked by uid 99); 2 Sep 2016 11:20:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 11:20:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DFCA32C1B84 for ; Fri, 2 Sep 2016 11:20:20 +0000 (UTC) Date: Fri, 2 Sep 2016 11:20:20 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-8115) Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 02 Sep 2016 11:20:22 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458254#comment-15458254 ] Jacques Le Roux commented on OFBIZ-8115: ---------------------------------------- I see not problem with the point 2, but the point 1 is more complex (I wonder why Eclipse would be wrong) and I'll double check all details... > Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse) > ----------------------------------------------------------------------------- > > Key: OFBIZ-8115 > URL: https://issues.apache.org/jira/browse/OFBIZ-8115 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Branch > > > At r1758927 I tried to fixe a bunch of closes missing, reported as warnings in Eclipse > Jacopo noticed and reported on dev ML http://markmail.org/message/b4hvzi7foftfq3j5 2 possible issues: > # you are adding a close statement to code that already had the close statement in the "finally" block; your modification actually introduces a code pattern that is not correct (if an exception is thrown your close statement are not executed) > # I suspect that you are closing the socket connection too early in PcChargeApi > So I reverted r1758927 to check the issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)