ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rishi Solanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7272) Enforce noninstantiability to all Utility classes
Date Sat, 27 Aug 2016 11:16:21 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441292#comment-15441292

Rishi Solanki commented on OFBIZ-7272:

[~arunpati]: Thanks for your help and committing all the changes. I have looked at all possible
classes and seems to me all the classes we could think of have been covered now. No new classes
from our side, I think we can close this ticket. In case we found any more class then we will
reopen this one. Thanks!

> Enforce noninstantiability to all Utility classes
> -------------------------------------------------
>                 Key: OFBIZ-7272
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7272
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>         Attachments: OFBIZ-7272.patch
> I have discusses this in past on mailing list, that Utility, helper, worker classes which
contains only static methods should not be instantiable. Also we can restrict it by adding
a private constructor.
> Currently OFBiz has many such classes which should have private constructor. Identify
all the *Worker.java, *.Helper.java, and *Util.java which do not have any non static method/member
are eligible for having a private constructor.
> Reference why we should do this : http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4

This message was sent by Atlassian JIRA

View raw message