From dev-return-110204-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon Feb 12 19:43:13 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B1CF7180652 for ; Mon, 12 Feb 2018 19:43:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A038F160C3F; Mon, 12 Feb 2018 18:43:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFBD6160C30 for ; Mon, 12 Feb 2018 19:43:12 +0100 (CET) Received: (qmail 10985 invoked by uid 500); 12 Feb 2018 18:43:11 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 10957 invoked by uid 99); 12 Feb 2018 18:43:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Feb 2018 18:43:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 96FDAC0042 for ; Mon, 12 Feb 2018 18:43:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id L5jHHlue13Xh for ; Mon, 12 Feb 2018 18:43:09 +0000 (UTC) Received: from mail-yw0-f177.google.com (mail-yw0-f177.google.com [209.85.161.177]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 451225F666 for ; Mon, 12 Feb 2018 18:43:08 +0000 (UTC) Received: by mail-yw0-f177.google.com with SMTP id b16so10571254ywh.12 for ; Mon, 12 Feb 2018 10:43:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=O76F0h+wkHYxCbyx0ufO7bSUnBphK+ucMZnfReVbk6I=; b=XPTqzl2IypbgpEZgDl50ni6QooSF8s7P5reWCogQ77MItKSCy1fO/pActtOtM/649P oW8OjXI6T+VzeXW92YtpYTNX5MXPwTi6WlFuBlHOgzwqXkI/CMdCL+0Q/kP0BlQhfY4f Xch0F8aiWAcKMcjY8QNWE1vGljnyAVdGUP9rLqINViyzL4kkRX9gEUsoGAZ+1Xhe6vC6 XcqjkW+SVlb7GFquRXQCFwyVzWe3sVy4FtxX3Ztg0kT/k2HW430eMjA9fPeP7oky+GR2 Su2u9pKVarHVv8xaJqslVBnsQc3uW5WcMdhH7xaQgsClEWj9d8JAD5d69wZtDryE1o2n z+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=O76F0h+wkHYxCbyx0ufO7bSUnBphK+ucMZnfReVbk6I=; b=D4zkCRIhKZ+6eGhyEdMpI21+kSiBwL2mzcTxdp1m2LZ0sIa/qld74bqM/KkeXcAL7B mgpzfzjuUL2qPHXNM0jWfy4F6PwUp6Xag5whaU9qX1WclDZbOxtKEaQ0IggZYX2YObaV sBIZv2uCOS0DSxfYzH3TRI7+FxEFEKBxQVlS4xa/UhSQT5kMs/SpW8tr5yMCdfs6K7mT AP6hGaY6gKyWdlS3ApwnYOz5zWA2ywX/PX/nt+GtRGG7RiVVWF2Mu58IrsSZdUXteIts jp/0GnMgrgQjRhPCbyHwj7sJExvDE+n5yUlDrzyeqrPBVpOSe5MnAu/rFgTnoFUl3BPB C1vw== X-Gm-Message-State: APf1xPBUdRpsM67I8ri9mwdUNbvJ6UGz0InEYAbshHRm7zu+QcyVXRO3 lQnFivnt5+wFRy1dEVot/nDH9+I3c5+1K0I/5Kg= X-Google-Smtp-Source: AH8x22406rsWeSaJxHoJXiRvzns3lg8Z+E5UnBu1WIUw2fUOLvv198zQzKneRQwMvE5Ih38GMcjKTuehgEZEcVaw0Zk= X-Received: by 10.129.85.3 with SMTP id j3mr8238818ywb.351.1518460980614; Mon, 12 Feb 2018 10:43:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.224.20 with HTTP; Mon, 12 Feb 2018 10:43:00 -0800 (PST) In-Reply-To: References: <299b5996-aab6-dc21-5592-c299f98a5eb5@nereide.fr> From: Taher Alkhateeb Date: Mon, 12 Feb 2018 21:43:00 +0300 Message-ID: Subject: Re: Overriding eca definition To: OFBIZ Development Mailing List Content-Type: text/plain; charset="UTF-8" I was actually thinking of the same thing, I like to have more sophistication in the conditions to create more robust graphs of service calls. +1 On Mon, Feb 12, 2018 at 12:08 PM, Arun Patidar wrote: > +1 for condition service attribute. > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > > www.hotwaxsystems.comwww.hotwax.co > > > On Sat, Feb 10, 2018 at 7:25 PM, Rishi Solanki > wrote: > >> Suraj/Nicolas, >> >> IMO, There is no need to extend/override an ECA rule. ECA like we want to >> trigger something conditionally and it happens once we establish the rule. >> We can change the rule, and we are doing that frequently as per our custom >> requirement and we have calls to disable sometimes when required. >> >> +1 for having condition-service tag, it should be useful for adding more >> proper conditions for running EECAs. >> >> Thanks! >> >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Sat, Feb 10, 2018 at 6:12 PM, Suraj Khurana < >> suraj.khurana@hotwaxsystems.com> wrote: >> >> > Hi Nicolas, >> > >> > I think there is a confusion here. >> > I am trying to find the reason why condition-service have not been >> > implemented for ecas? >> > I there is no such reason, I propose we should have a similar concept for >> > ecas as well. >> > So that we can write something like: >> > >> > >> > > > value="ORDER_COMPLETED"/> >> > > > value="Y"/> >> > >> > >> > >> > >> > Here, checkForSomeCondition service must return true to proceed for >> > issueImmediatelyFulfilledOrder. >> > HTH. >> > >> > -- >> > Thanks and Regards, >> > *Suraj Khurana* | Sr. Enterprise Software Engineer >> > *HotWax Commerce* by *HotWax Systems* >> > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >> > >> > On Sat, Feb 10, 2018 at 1:35 PM, Nicolas Malin > > >> > wrote: >> > >> > > Hello Suraj, >> > > >> > > Currently I see no possibility to override an eca because definitions >> are >> > > all loaded and we can have exactly two identical definition with >> > different >> > > action. In this case difficult to spot the eca to disable/improve. >> > > >> > > So before try to override an eca I suggest to implement an >> identification >> > > like : >> > > >> > > > event="return" >> > > package="org.apache.ofbiz.accounting" >> > id="FinAccountTransBalanceUpda >> > > te"> >> > > > > > value="FINACT_TRNS_APPROVED"/> >> > > > > mode="sync"/> >> > > >> > > >> > > and after we would implement a new element as flying idea : >> > > > > > id="FinAccountTransBalanceUpdate"> >> > > >> > > > > > value="LOVE"/> >> > > >> > > >> > > or >> > > > > > id="FinAccountTransBalanceUpdate"> >> > > or >> > > > > > id="FinAccountTransBalanceUpdate"> >> > > >> > > > > > value="LOVE"/> >> > > >> > > >> > > >> > > >> > > Nicolas >> > > >> > > >> > > >> > > On 09/02/2018 14:01, Suraj Khurana wrote: >> > > >> > >> Hello, >> > >> >> > >> What is the best way to override entity eca definition? >> > >> Suppose you need to add a condition-service as well in eca, as far as >> I >> > >> can >> > >> check, currently, there is no way to handle condition service in eca >> > rule. >> > >> >> > >> IMO, this could be interesting to have this thing, is it intentional >> > that >> > >> we do this only for seca rules and not for eca's? >> > >> >> > >> Please share your thoughts on this. >> > >> -- >> > >> Thanks and Regards, >> > >> *Suraj Khurana* | Omnichannel OMS Technical Expert >> > >> *HotWax Commerce* by *HotWax Systems* >> > >> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >> > >> >> > >> >> > > >> > >>