Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
MIME-Version: 1.0
In-Reply-To: <CAAAytYrhAjdBqjC3=7Mdy4c2W0YPsKp1p9_av-zzEpFcbJNduA@mail.gmail.com>
References: <CAAAytYqZzp3FfX=-H3QqZqfg3wuaKQhtXX1PWE-hk4erGxGsbw@mail.gmail.com>
 <CAFqjAi3db-cTyrfZ13MeWcxvwAS=DzEjPNnvWgobqfPNvDi3AQ@mail.gmail.com> <CAAAytYrhAjdBqjC3=7Mdy4c2W0YPsKp1p9_av-zzEpFcbJNduA@mail.gmail.com>
From: Taher Alkhateeb <slidingfilaments@gmail.com>
Date: Sat, 7 Oct 2017 09:09:33 +0300
Message-ID: <CAFqjAi1eb9LnC=w13NJfgo4WouMCbK9i3s81JVjZrMnbJ_oH9g@mail.gmail.com>
Subject: Re: Components loading twice while starting OFBiz
To: OFBIZ Development Mailing List <dev@ofbiz.apache.org>
Content-Type: multipart/alternative; boundary="001a113d31ac328536055aeecd70"
archived-at: Sat, 07 Oct 2017 06:09:42 -0000

--001a113d31ac328536055aeecd70
Content-Type: text/plain; charset="UTF-8"

Hello Yash

Great, we'll continue this discussion in OFBIZ-9827. Thank you for your
kind words.

On Oct 7, 2017 7:25 AM, "Yash Sharma" <yash.sharma@hotwaxsystems.com> wrote:

Hello Taher,

Thanks for your quick response, I am a big fan of your work for that. Yes
this behaviour exists in 14.12 also, I have created JIRA ticket for that
OFBIZ-9827 <https://issues.apache.org/jira/browse/OFBIZ-9827>.

Thanks & Regards,
--
*Pradhan Yash Sharma*
*HotWax Systems* | www.hotwaxsystems.com

On Fri, Oct 6, 2017 at 10:57 PM, Taher Alkhateeb <slidingfilaments@gmail.com
> wrote:

> Hello Yash,
>
> I've made a full refactoring exercise of the CatalinaContainer a while
> ago, however I don't think that work altered the behavior. Perhaps
> this is an existing bug (not sure).
>
> Either way, I'm familiar with that code and if you'd like to open a
> JIRA I can try to help out. I never liked the whole logic for loading
> webapps, so this might be a good time to fix the bug and improve the
> logic in this class.
>
> On Fri, Oct 6, 2017 at 3:57 PM, Yash Sharma
> <yash.sharma@hotwaxsystems.com> wrote:
> > Hi Dev,
> >
> > I was looking at some components loading twice while starting OFBiz.
> > While digging it deep down I found CatalinaContainer calls loadWebapps
> > which creates a future task which depends on numbers of System cores.
> > If web app mounts are not available it removes all and adds again all
> Apps
> > Mounts which submits all task to future. Which creates a condition where
> >
> > 1) if 2 cores are available task some task is added to the future pool
> > twice.
> > 2) if 4 cores are available only task one task is added to the future
> pool
> > twice.
> >
> > (These values totally depend on system speed and number of cores
> available
> > but the point is slow system will submit few task more than once and
> faster
> > vice versa)
> >
> > I am looking around this piece of code and trying to resolve this
problem
> > if someone else has gone through this please let me know.
> >
> >
> > Thanks & Regards,
> > --
> > *Pradhan Yash Sharma*
> > *HotWax Systems* | www.hotwaxsystems.com
>

--001a113d31ac328536055aeecd70--