ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacques Le Roux <jacques.le.r...@les7arts.com>
Subject Re: [Site] OFBIZ-9665
Date Wed, 04 Oct 2017 08:40:54 GMT
Done at r1811050

Jacques


Le 03/10/2017 à 12:07, Aditya Sharma a écrit :
> Interesting. Thanks Deepak for sharing that.
>
> +1 for having target="external" at all places as consistency is key to good
> user experience.
>
> Thanks and Regards,
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/>
> <https://www.linkedin.com/in/aditya-sharma-78291810a/>
>
> On Tue, Oct 3, 2017 at 2:00 PM, Devanshu Vyas <vyas.devanshu16@gmail.com>
> wrote:
>
>> Thanks Deepak, I looked for similar info, but was unable to find. And in
>> the meantime, got to know about the Rel attribute, so I thought the
>> intended code was rel rather than target='external'.
>> Now, with the new information at hand, I think target="_blank" or
>> target="external" both are correct. All we need to decide is whether to
>> open all links in separate tabs everytime link is clicked or just once.
>>
>> I think we should open all external links with target="external". WDYAS?
>>
>> Thanks & Regards,
>> Devanshu Vyas.
>>
>> On Tue, Oct 3, 2017 at 1:58 PM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> Ha thanks Deepak,
>>>
>>> This is interesting (and surprising), so we should change ALL
>>> target="_blank" to target="external" rather for consistency sake
>>>
>>> If everybody agree I will do so
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 03/10/2017 à 10:18, Deepak Dixit a écrit :
>>>
>>>> Hi Devanshu,
>>>>
>>>> I think target="external" is correct.
>>>>
>>>> https://www.quackit.com/html/codes/html_open_link_in_new_window.cfm
>>>>
>>>> {info}
>>>> Instead of calling your window _blank, you can give it a name of your
>>>> choosing. Then all URLs will load in that same tab (as long as you use
>> the
>>>> same name).
>>>>
>>>> For example, if you have a policy of loading all external links in a
>>>> separate tab, you could call that tab, say, external. Then each link
>> that
>>>> contains target="external" will open in that window/tab. Doing this
>>>> ensures
>>>> that new windows aren't going to be popping up every time a user clicks
>> on
>>>> a link.
>>>>
>>>> {info}
>>>>
>>>> Thanks & Regards
>>>> --
>>>> Deepak Dixit
>>>> www.hotwaxsystems.com
>>>> www.hotwax.co
>>>>
>>>> On Tue, Oct 3, 2017 at 1:40 PM, Devanshu Vyas <
>> vyas.devanshu16@gmail.com>
>>>> wrote:
>>>>
>>>> Hello,
>>>>> I agree with Jacques and Aditya, we should set all external links with
>>>>> target="_blank". I have also mentioned the same on the JIRA ticket
>>>>> <https://issues.apache.org/jira/browse/OFBIZ-9665>.
>>>>> I think the intended use is rel="external", which was somehow written
>> as
>>>>> target="external", refer: https://www.w3schools.com/Tags/att_a_rel.asp
>>>>>
>>>>> Hope this helps!
>>>>>
>>>>> Thanks & Regards,
>>>>> Devanshu Vyas.
>>>>>
>>>>> On Tue, Oct 3, 2017 at 12:18 PM, Taher Alkhateeb <
>>>>> slidingfilaments@gmail.com
>>>>>
>>>>>> wrote:
>>>>>> AFAIK "_blank" is the only acceptable target in HTML 5 because frames
>>>>>> are deprecated. The website is modern and built on an HTML 5 template.
>>>>>> Hence every target should be "_blank"
>>>>>>
>>>>>> On Tue, Oct 3, 2017 at 9:42 AM, Jacques Le Roux
>>>>>> <jacques.le.roux@les7arts.com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Aditya and I want to change all "external" targets to "_blank"
but
>> are
>>>>>>> unsure of the reason of "external" targets
>>>>>>>
>>>>>>> Could someone please confirm it's not an issue and maybe explain
why
>> we
>>>>>> have
>>>>>>
>>>>>>> "external" targets
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>


Mime
View raw message