ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Brohl <michael.br...@ecomify.de>
Subject Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java RecordIterator.java
Date Sun, 29 Oct 2017 09:53:53 GMT
I think this is just a formatting change becaused I used our formatter 
for Eclipse.

Not really something worth a discussion, is it?


Am 29.10.17 um 10:07 schrieb Jacques Le Roux:
> Le 28/10/2017 à 16:45, mbrohl@apache.org a écrit :
>> -        for (int i = 0; i < modelField.length; i++)
>> -            sb.append(PAD_CHAR);
>> -        data = sb.toString();
>> -        }
>> +                for (int i = 0; i < modelField.length; i++)
>> +                    sb.append(PAD_CHAR);
>> +                data = sb.toString();
>> +            }
> Hi All,
>
> I find this ambiguous. We have few options here:
>
> 1)
>                 for (int i = 0; i < modelField.length; i++)
>                     sb.append(PAD_CHAR);
>
>                 data = sb.toString();
>
> 2)
>                 for (int i = 0; i < modelField.length; i++) {
>                     sb.append(PAD_CHAR);
>                 }
>                 data = sb.toString();
>
> 3)
>                 for (int i = 0; i < modelField.length; i++) 
> sb.append(PAD_CHAR);
>                 data = sb.toString();
>
> 4)
>                 for (int i = 0; i < modelField.length; i++) 
> sb.append(PAD_CHAR);
>
>                 data = sb.toString();
>
> Which one do you prefer? Of course this should be a general rule, not 
> only for this case!
>
> Thanks
>
> Jacques
>

Mime
View raw message