ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Taher Alkhateeb <slidingfilame...@gmail.com>
Subject Re: svn commit: r1798104 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntityListIterator.java
Date Fri, 09 Jun 2017 10:49:59 GMT
I think this log message looks bad in addition to being platform dependent
with EOL character. Perhaps it should be properly formatted as it looks off
and 220 characters wide for no good reason.

On Thu, Jun 8, 2017 at 9:39 PM, <jleroux@apache.org> wrote:

> Author: jleroux
> Date: Thu Jun  8 18:39:23 2017
> New Revision: 1798104
>
> URL: http://svn.apache.org/viewvc?rev=1798104&view=rev
> Log:
> No functional change.
>
> Adds a suggestion to report in case of EntityListIterator Not Closed
>
> Modified:
>     ofbiz/ofbiz-framework/trunk/framework/entity/src/main/
> java/org/apache/ofbiz/entity/util/EntityListIterator.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/
> java/org/apache/ofbiz/entity/util/EntityListIterator.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/entity/src/main/java/org/apache/ofbiz/entity/
> util/EntityListIterator.java?rev=1798104&r1=1798103&r2=1798104&view=diff
> ============================================================
> ==================
> --- ofbiz/ofbiz-framework/trunk/framework/entity/src/main/
> java/org/apache/ofbiz/entity/util/EntityListIterator.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/entity/src/main/
> java/org/apache/ofbiz/entity/util/EntityListIterator.java Thu Jun  8
> 18:39:23 2017
> @@ -525,7 +525,8 @@ public class EntityListIterator implemen
>          try {
>              if (!closed) {
>                  this.close();
> -                Debug.logError("\n============
> ========================================================\n
> EntityListIterator Not Closed for Entity [" + (modelEntity==null ? "" :
> modelEntity.getEntityName()) + "], caught in Finalize\n
> ====================================================================\n",
> module);
> +                Debug.logError("\n============
> ==================================================================\n
> EntityListIterator Not Closed for Entity [" + (modelEntity==null ? "" :
> modelEntity.getEntityName())
> +                        + "], caught in Finalize\n Please report by
> creating an OFBIZ-9297 subtask with the stack trace,
> thanks\n==============================================================================\n",
> module);
>              }
>          } catch (Exception e) {
>              Debug.logError(e, "Error closing the SQLProcessor in finalize
> EntityListIterator", module);
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message