ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Taher Alkhateeb <slidingfilame...@gmail.com>
Subject Re: Removing failing tests from framework
Date Wed, 10 May 2017 10:18:46 GMT
Hi Jacques, why do you want to reintroduce the tests?

On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Hi Taher,
>
> The test have been removed, please create a Jira to not forget to put the
> test again later.
>
> Thanks
>
> Jacques
>
>
>
> Le 02/05/2017 à 11:27, Jacques Le Roux a écrit :
>
>> It's OK with me if we later reintroduce this test and create a Jira for
>> that
>>
>> Jacques
>>
>>
>> Le 02/05/2017 à 11:24, Jacques Le Roux a écrit :
>>
>>> Hi Taher,
>>>
>>> Please give me an hour to review, I did not look at it yet
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit :
>>>
>>>> Hey folks. I see no one replied so far on this. I'm not a big fan of
>>>> lazy
>>>> consensus, but I will proceed in this case because the patch is very
>>>> small
>>>> and two minor tests will be removed/modified for the sake of building
>>>> ofbiz-framework independently.
>>>>
>>>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb <
>>>> slidingfilaments@gmail.com> wrote:
>>>>
>>>> Hello Everyone,
>>>>>
>>>>> I've been doing a lot of work lately in [1] to be able to build
>>>>> ofbiz-framework and run all tests successfully without pulling any
>>>>> plugins
>>>>> in.
>>>>>
>>>>> After lots and lots of test runs, trial-and-error, and deep code
>>>>> debugging
>>>>> I was able to bring down the total failing tests from hundreds to only
>>>>> two.
>>>>> I believe the two remaining tests are fundamentally incorrect because
>>>>> they
>>>>> assume the existence of data, scripts and widgets in ecommerce and I
>>>>> explained this issue more thoroughly in [2]
>>>>>
>>>>> Therefore, I made a patch [3] which simply removes the tests /
>>>>> portions of
>>>>> tests which are causing the failures. This is a quick solution to get
>>>>> the
>>>>> ofbiz-framework to build and test successfully without plugins.
>>>>>
>>>>> The real solution, however, requires a very deep look into the order
>>>>> component and to remove all dependencies on ecommerce. This is a lot
of
>>>>> work, and should be done gradually over time.
>>>>>
>>>>> So my recommendation is to apply the patch, and create a JIRA to
>>>>> gradually
>>>>> remove remaining entanglements from order to ecommerce.
>>>>>
>>>>> WDYT?
>>>>>
>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322
>>>>> [2] https://s.apache.org/DlGE
>>>>> [3] https://issues.apache.org/jira/secure/attachment/
>>>>> 12865667/OFBIZ-9322.patch
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>>
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message