Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Subject: Re: svn commit: r1791143 -
 /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle
To: dev@ofbiz.apache.org
References: <20170412163859.6C5013A0597@svn01-us-west.apache.org>
	<CAFqjAi2MTeP05W9o9dTgs-6Ove=waqQzYseAX59rzc720GhnDQ@mail.gmail.com>
	<6eba933b-0543-deaf-3e11-33c73e493f97@les7arts.com>
	<CAFqjAi0i272G=jOpBgR2D-4z6UVOnYuWiwE9w2FuBFw4Bdcq6Q@mail.gmail.com>
From: Jacques Le Roux <jacques.le.roux@les7arts.com>
Organization: Les Arts Informatiques
Message-ID: <6572de6e-5c2f-4238-5b16-7cac80f325f3@les7arts.com>
Date: Wed, 12 Apr 2017 21:16:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
	Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: 
	<CAFqjAi0i272G=jOpBgR2D-4z6UVOnYuWiwE9w2FuBFw4Bdcq6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Wed, 12 Apr 2017 19:16:22 -0000

Le 12/04/2017 à 19:44, Taher Alkhateeb a écrit :
> Your reply indicates that you do not understand what you committed Jacques!

I trust Swapnil and Deepak and tested the change which worked. But as I said in the Jira it was a random issue for me so hard to test!

> You don't need to go far to know what is the problem, it's right there in
> front of you, it's in this email thread with the EXACT line that's causing
> the problem. Let me give you a hint:
>
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> type org.gradle.api.DefaultTask.

That was not obvious to me, not to Deepak and Swapnil it seems. It's easier to fix your (not you personally, in general) own errors. Thanks for 
finally fixing it at r1791168.

> You are fixing incorrect code by commenting out what's triggering it, which
> is also triggered by an incorrect earlier revert from you.

Which "incorrect earlier revert"? Without knowing what I did wrong I'll not progress...

Jacques
>
> On Wed, Apr 12, 2017 at 8:35 PM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Please explain more or point to links where it's already explained
>>
>> Thanks
>>
>> Jacques
>>
>>
>>
>> Le 12/04/2017 à 18:54, Taher Alkhateeb a écrit :
>>
>>> This commit is completely wrong and poorly thought and does not fix the
>>> root cause.
>>>
>>> Please revert
>>>
>>> On Wed, Apr 12, 2017 at 7:38 PM, <jleroux@apache.org> wrote:
>>>
>>> Author: jleroux
>>>> Date: Wed Apr 12 16:38:59 2017
>>>> New Revision: 1791143
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1791143&view=rev
>>>> Log:
>>>> Fixed: The createTenant Gradle task fails
>>>> (OFBIZ-9273)
>>>>
>>>> Problem:
>>>> When you enter
>>>> bq. gradlew createTenant -PtenantId=test
>>>> you get
>>>> FAILURE: Build failed with an exception.
>>>> * Where:
>>>> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
>>>> * What went wrong:
>>>> A problem occurred evaluating root project 'ofbiz'.
>>>>
>>>>> Could not get unknown property 'pluginId' for task ':installAllPlugins'
>>>>>
>>>> of
>>>> type org.gradle.api.DefaultTask.
>>>>
>>>> Investigation:
>>>> This issue is due creation of build.gradle file in plugin (with empty
>>>> gradle
>>>> task defined in it)
>>>>
>>>> Solution:
>>>> Comment out build.gradle template content
>>>>
>>>> Thanks: Deepak for confirmation, Swapnil M Mane for the investigation and
>>>> patch
>>>>
>>>> Modified:
>>>>       ofbiz/ofbiz-framework/trunk/framework/resources/templates/b
>>>> uild.gradle
>>>>
>>>> Modified: ofbiz/ofbiz-framework/trunk/framework/resources/templates/
>>>> build.gradle
>>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
>>>> framework/resources/templates/build.gradle?rev=1791143&r1=
>>>> 1791142&r2=1791143&view=diff
>>>> ============================================================
>>>> ==================
>>>> --- ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
>>>> ild.gradle
>>>> (original)
>>>> +++ ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
>>>> ild.gradle
>>>> Wed Apr 12 16:38:59 2017
>>>> @@ -1,3 +1,4 @@
>>>> +/*
>>>>    dependencies {
>>>>        //Examples of compile-time and runtime dependencies
>>>>
>>>> @@ -16,3 +17,4 @@ task uninstall {
>>>>            // uninstall logic for this plugin
>>>>        }
>>>>    }
>>>> +*/
>>>>
>>>>
>>>>
>>>>