ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacques Le Roux <jacques.le.r...@les7arts.com>
Subject Re: Remove unused labels?
Date Thu, 15 Sep 2016 19:28:40 GMT
Le 15/09/2016 à 21:19, Taher Alkhateeb a écrit :
> I think unused labels should be removed. I also think it is not too hard to
> find and delete all such labels in one shot. We can develop a script to do
> that and use it on a recurring basis actually.

Actually this already exists, and it's maybe not as simple as you would think, see https://issues.apache.org/jira/browse/OFBIZ-8154

Jacques

> Unfortunately we have unused XML not only in labels but many other XML
> resources making them dead code. This is an area ripe for refactoring.
>
> On Sep 15, 2016 10:13 PM, "Pierre Smits" <pierre.smits@gmail.com> wrote:
>
>> Maybe we should discuss each individual label? Or do you believe you can
>> use your own judgement to do the right thing?
>>
>> Pierre Smits
>>
>> ORRTIZ.COM <http://www.orrtiz.com>
>> OFBiz based solutions & services
>>
>> OFBiz Extensions Marketplace
>> http://oem.ofbizci.net/oci-2/
>>
>> On Thu, Sep 15, 2016 at 9:09 PM, Pierre Smits <pierre.smits@gmail.com>
>> wrote:
>>
>>> That goes to show that not much attention was paid when they got in.
>>>
>>> Pierre Smits
>>>
>>> ORRTIZ.COM <http://www.orrtiz.com>
>>> OFBiz based solutions & services
>>>
>>> OFBiz Extensions Marketplace
>>> http://oem.ofbizci.net/oci-2/
>>>
>>> On Thu, Sep 15, 2016 at 8:50 PM, jleroux@apache.org <jleroux@apache.org>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> While working on OFBIZ-8154 I noticed that the labels beginning by
>>>> "HumanResServices." are never used.
>>>>
>>>> So, it's a pity, but I think they should be removed. Actually my
>> question
>>>> is more if we agree about removing all unused labels, not only those
>> ones.
>>>> Thanks
>>>>
>>>


Mime
View raw message