ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
Date Mon, 11 Jul 2016 16:24:11 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371096#comment-15371096

Pierre Smits commented on OFBIZ-7532:

I see nothing wrong with this issue. It is a sound improvement.

And the patch looks equally fine.

We don't need discuss a trivial aspect like the validation of choices. There are lots of best
practices that can be found. It only needs one to start with. The rest can be covered through
follow-up JIRA issues.

I don't believe we need contributors second-guessing their judgement after they have created
their issues with the best of intentions, by doing a do-over of the issue in a mail thread
in the dev mailing list.

The only thing I find missing in the patch is addressing the properties for multi-tenant usage,
meaning an enhancement of the seed data set with respect to the SystemProperty value(s) desired.
See OFBIZ-6164

> Form Display Field improvement to manage multiple number format
> ---------------------------------------------------------------
>                 Key: OFBIZ-7532
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7532
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Charles STELTZLEN
>            Priority: Minor
>         Attachments: OFBIZ-7532.patch
> On display field used in forms, there is a "type" "accounting-number" which is used to
format number like property configuration :  #,##0.0000;(#,##0.0000).
> This JIRA propose to extend this idea by using a "type" "number" and an additional attribute
called "format-pattern". This field will be used by form renderer to get the good property.
It use FlexibleString to manage variable in this field and so allow to have different format
for the same column according to some conditions.
> example: <field name="amount"><display type="number" format-pattern="accounting"/></field>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.0000;(#,##0.0000)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using EntityUtilProperties.getPropertyValue
to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the choices.

This message was sent by Atlassian JIRA

View raw message