ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Taher Alkhateeb <slidingfilame...@gmail.com>
Subject Removing multiple commands and related files for OFBiz server
Date Thu, 21 Jul 2016 09:38:21 GMT
Hello Everyone,

This is a proposal to _remove_ the following commands from the OFBiz server
(invoked with ./gradlew "ofbiz --commandHere"

1- --both
2- --pos
3- --testlist

Reasons:
- The POS component is a specialpurpose component and should not have code
existing in the start component. Instead logic for starting the POS
component should reside inside the POS component and away from framework
- After lots of investigation I realized the testlist OFBiz command is a
weird command that used to create an ant file that just iterates over the
existing integration test suites and run them one by one, which is slower
vs just running them all. It is deprecated and to my knowledge no one is
using it. I think it used to serve some deprecated cobertura tasks.

This would imply deleting the following files:
-
framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties
-
framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java
-
framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java

and modifying the following files:
- framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java
-
framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java
- (move it to POS)
framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java

Agreed?

Regards,

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message