Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05CA9200AE4 for ; Fri, 24 Jun 2016 16:03:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 04674160A62; Fri, 24 Jun 2016 14:03:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7361A160A2E for ; Fri, 24 Jun 2016 16:03:17 +0200 (CEST) Received: (qmail 74409 invoked by uid 500); 24 Jun 2016 14:03:16 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 74390 invoked by uid 99); 24 Jun 2016 14:03:16 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2016 14:03:16 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4474A2C1F5C for ; Fri, 24 Jun 2016 14:03:16 +0000 (UTC) Date: Fri, 24 Jun 2016 14:03:16 +0000 (UTC) From: "Rohit Koushal (JIRA)" To: dev@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (OFBIZ-7587) Enforce noninstantiability to UtilFormatOut class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 24 Jun 2016 14:03:18 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7587: ------------------------------------ Assignee: Rohit Koushal > Enforce noninstantiability to UtilFormatOut class > ------------------------------------------------- > > Key: OFBIZ-7587 > URL: https://issues.apache.org/jira/browse/OFBIZ-7587 > Project: OFBiz > Issue Type: Sub-task > Components: framework > Affects Versions: Trunk > Reporter: Rishi Solanki > Assignee: Rohit Koushal > Priority: Minor > > - Make class as final. > - Add a private constructor. > - Make the following static variable as private static final. Also move it to begining of the class with FIXME: comment > {code} > // ------------------- price format handlers ------------------- > // FIXME: This is not thread-safe! DecimalFormat is not synchronized. > static DecimalFormat priceDecimalFormat = new DecimalFormat(UtilProperties.getPropertyValue("general", "currency.decimal.format", "#,##0.00")); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)