ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rishi Solanki (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-7591) Enforce noninstantiability to UtilJavaParse class
Date Fri, 24 Jun 2016 09:30:16 GMT
Rishi Solanki created OFBIZ-7591:
------------------------------------

             Summary: Enforce noninstantiability to UtilJavaParse class
                 Key: OFBIZ-7591
                 URL: https://issues.apache.org/jira/browse/OFBIZ-7591
             Project: OFBiz
          Issue Type: Sub-task
          Components: framework
    Affects Versions: Trunk
            Reporter: Rishi Solanki
            Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private and move them to top of class. Also
move the static block initializing it.
{code}
        // FIXME: Not thread safe
    public static Set<String> serviceMethodNames = new HashSet<String>();
    static {
        serviceMethodNames.add("runSync");
        serviceMethodNames.add("runSyncIgnore");
        serviceMethodNames.add("runAsync");
        serviceMethodNames.add("runAsyncWait");
        serviceMethodNames.add("registerCallback");
        serviceMethodNames.add("schedule"); // NOTE: the service name may be the 1st, 2nd
or 3rd param for variations on this
        serviceMethodNames.add("addRollbackService");
        serviceMethodNames.add("addCommitService");
    }

{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message