ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Pandey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
Date Wed, 22 Jun 2016 09:33:57 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344002#comment-15344002
] 

Pranay Pandey commented on OFBIZ-7519:
--------------------------------------

Hi Jacques,

Thanks for your comment. I don't think both of these are the same thing. The changes committed
under this patch are to correct server side validations of input parameters to a service.
[OFBIZ-7511] is talking about enhancement in Form-Widget to enforce right client side validation.

> Some entity-auto services fields doesn't have optional false in case of multiple PK's
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7519
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7519
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, content, marketing
>    Affects Versions: Trunk
>            Reporter: Amardeep Singh Jhajj
>            Assignee: Pranay Pandey
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of multiple PK's.
In this cases if any of the PK is missing then sql error returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary primary
key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message