ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-6783) Refactor start.java
Date Thu, 12 May 2016 09:36:12 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281370#comment-15281370
] 

Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------

I totally agree, it's far better. When it will be committed, I'll update the wiki documentation.
I mean at least [that|https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Technical+Production+Setup+Guide?focusedCommentId=50234714#comment-50234714]

But before, we still need to check things of course... Should not be too long...

> Refactor start.java
> -------------------
>
>                 Key: OFBIZ-6783
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6783
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Branch
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>              Labels: framework, main, refactoring, start
>         Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I would like
to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given
that this is an important file, I will provide a patch to be reviewed by the community before
committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message