ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vishal Chhabria (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-6685) changeProductionRunStatus service does not honor the StatusValidChange
Date Sat, 16 Jan 2016 08:00:54 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103059#comment-15103059
] 

Vishal Chhabria edited comment on OFBIZ-6685 at 1/16/16 7:59 AM:
-----------------------------------------------------------------

[~deepakdixit] 
I think few improvement as required in your patch, I have update the patch with following
changes -  
1) Passed statusId 'PRUN_DOC_PRINTED' as hidden paramater when user 'Confirm' any Production
Run. Currently, no statusId is passed and service returns error when we Confirm Production
Run.
2) Set statusId as mandatory parameter for the service as no record is found for ValidStatusChange
with StatusId="null", service will always return error if no statusId is passed so IMO statusId
should be mandatory in that case.
3) Changed request-name 'changeProductionRunStatusToPrinted' to changeProductionRunStatus
to make it generic and can be called from anywhere to change the production run status, also
removed request changeProductionRunStatusToClosed as I do not find this request being called
from anywhere.
4) Added data for ValidStatusChange.


was (Author: vishal.chhabria):
[~deepakdixit] I have attached a patch with below mentioned improvements - 
1) Passed statusId 'PRUN_DOC_PRINTED' as hidden paramater when user 'Confirm' any Production
Run. Currently, no statusId is passed and service returns error when we Confirm Production
Run.
2) Set statusId as mandatory parameter for the service as no record is found for ValidStatusChange
with StatusId="null", service will always return error if no statusId is passed so IMO statusId
should be mandatory in that case.
3) Changed request-name 'changeProductionRunStatusToPrinted' to changeProductionRunStatus
to make it generic and can be called from anywhere to change the production run status, also
removed request changeProductionRunStatusToClosed as I do not find this request being called
from anywhere.
4) Added data for ValidStatusChange.

> changeProductionRunStatus service does not honor the StatusValidChange 
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-6685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6685
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing
>    Affects Versions: Trunk
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>         Attachments: OFBIZ-6685.patch, OFBIZ-6685.patch
>
>
> As per current implementation changeProductionRunStatus does not honor the StatusValidChange,
There are hard coded check in changeProductionRunStatus service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message