ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-6488) Replace facility/control/EditFacility with widgets
Date Sat, 20 Jun 2015 10:19:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594502#comment-14594502

Michael Brohl commented on OFBIZ-6488:


I reviewed and tested your patch. The behaviour is different as before because your have removed
some of the logical checks and fail-widget code.

In the current implementation, you can change the facilityId in the url and send it to the
server. The edit dialog is then filled with the (non-existing) facilityId. If this is updated,
you get an error because the facility is unknown (which is correct).

In your implementation, the fake facility Id is not shown in the dialog and if it is updated,
no error occurs.

Please review your patch or give me some feedback what your idea was removing the check and
error code.

> Replace facility/control/EditFacility with widgets
> --------------------------------------------------
>                 Key: OFBIZ-6488
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6488
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Branch
>            Reporter: Christian Carlow
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-6488.patch

This message was sent by Atlassian JIRA

View raw message