ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
Date Thu, 25 Jun 2015 03:11:06 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598918#comment-14598918
] 

Wei Zhang edited comment on OFBIZ-6362 at 6/25/15 3:10 AM:
-----------------------------------------------------------

I don't think we should hard code localization js files below to seed data

{code:borderStyle=solid}
     <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/ui/i18n/jquery.ui.datepicker-en.js" sequenceId="04"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/datejs/date-en-US.js" sequenceId="06"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/datetimepicker/localization/jquery-ui-timepicker-en.js"
sequenceId="08"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/validate/localization/messages_en.js" sequenceId="13"/>
{code}

And there is no way to output the localization js files defined GlobalActions in framework\common\widget\CommonScreens.xml
{code:borderStyle=solid}
  <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.jquery.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.validation.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.dateTime.getFilePath(initialLocaleComplete)}"
global="true" />
{code}



was (Author: tzngvi):
I don't think we should add localization js files below to seed data

{code:borderStyle=solid}
     <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/ui/i18n/jquery.ui.datepicker-en.js" sequenceId="04"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/datejs/date-en-US.js" sequenceId="06"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/datetimepicker/localization/jquery-ui-timepicker-en.js"
sequenceId="08"/>
    <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT"
resourceValue="/images/jquery/plugins/validate/localization/messages_en.js" sequenceId="13"/>
{code}

And there is no way to output the localization js files defined GlobalActions in framework\common\widget\CommonScreens.xml
{code:borderStyle=solid}
  <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.jquery.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.validation.getFilePath(initialLocaleComplete)}"
global="true" />
                <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.dateTime.getFilePath(initialLocaleComplete)}"
global="true" />
{code}


> Move js & css references from CommonDecorator(s) to themes
> ----------------------------------------------------------
>
>                 Key: OFBIZ-6362
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6362
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: Pierre Smits
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, OFBIZ-6362-BizznessTime-header.ftl.patch,
OFBIZ-6362-BizznessTimeThemeData.xml.patch, OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch,
OFBIZ-6362-DroppingCrumbs-header.ftl.patch, OFBIZ-6362-DroppingCrumbsThemeData.xml.patch,
OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, OFBIZ-6362-Tomahawk-header.ftl.patch,
OFBIZ-6362-TomahawkThemeData.xml.patch, OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch,
bbasic.zip, sunrise.zip
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message