Return-Path: X-Original-To: apmail-ofbiz-dev-archive@www.apache.org Delivered-To: apmail-ofbiz-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52E5010492 for ; Sat, 9 May 2015 20:48:00 +0000 (UTC) Received: (qmail 86802 invoked by uid 500); 9 May 2015 20:48:00 -0000 Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org Received: (qmail 86753 invoked by uid 500); 9 May 2015 20:48:00 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 86394 invoked by uid 99); 9 May 2015 20:47:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2015 20:47:59 +0000 Date: Sat, 9 May 2015 20:47:59 +0000 (UTC) From: "Pierre Smits (JIRA)" To: dev@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-6349) Replace ViewQuoteItems.ftl with form widgets MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536890#comment-14536890 ] Pierre Smits commented on OFBIZ-6349: ------------------------------------- I did a cursory review of the patch attached, and found a lot of lines that are commented out. Is there a reason why these are retained? I also see hardcoded currency settings. These won't fly in any organisation using OFBiz outside of the U.S. of A. > Replace ViewQuoteItems.ftl with form widgets > -------------------------------------------- > > Key: OFBIZ-6349 > URL: https://issues.apache.org/jira/browse/OFBIZ-6349 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: Trunk > Reporter: Christian Carlow > Attachments: OFBIZ-6349.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)