Return-Path: 
 <dev-return-88576-apmail-ofbiz-dev-archive=ofbiz.apache.org@ofbiz.apache.org>
X-Original-To: apmail-ofbiz-dev-archive@www.apache.org
Delivered-To: apmail-ofbiz-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BCDD81853F
	for <apmail-ofbiz-dev-archive@www.apache.org>;
 Fri, 29 May 2015 10:40:17 +0000 (UTC)
Received: (qmail 31393 invoked by uid 500); 29 May 2015 10:40:17 -0000
Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org
Received: (qmail 31365 invoked by uid 500); 29 May 2015 10:40:17 -0000
Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ofbiz.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ofbiz.apache.org>
List-Post: <mailto:dev@ofbiz.apache.org>
List-Id: <dev.ofbiz.apache.org>
Reply-To: dev@ofbiz.apache.org
Delivered-To: mailing list dev@ofbiz.apache.org
Received: (qmail 31354 invoked by uid 99); 29 May 2015 10:40:17 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 10:40:17 +0000
Date: Fri, 29 May 2015 10:40:17 +0000 (UTC)
From: "Pierre Smits (JIRA)" <jira@apache.org>
To: dev@ofbiz.apache.org
Message-ID: <JIRA.12780785.1425983611000.64651.1432896017399@Atlassian.JIRA>
In-Reply-To: <JIRA.12780785.1425983611000@Atlassian.JIRA>
References: <JIRA.12780785.1425983611000@Atlassian.JIRA>
 <JIRA.12780785.1425983611497@arcas>
Subject: [jira] [Comment Edited] (OFBIZ-6139) Lookup fields break when used
 with a form having skip-start="true"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/OFBIZ-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564549#comment-14564549 ] 

Pierre Smits edited comment on OFBIZ-6139 at 5/29/15 10:39 AM:
---------------------------------------------------------------

Having to have the form name hard coded in the field as in:
{code}
<form name="RequestItemProduct" type="single" skip-start="true" skip-end="true">
        <field name="productId" title="${uiLabelMap.CommonProduct}" form-name="EditCustRequestItem">
        <lookup target-form-name="LookupProduct" description-field-name="productName" show-description="false"/>
        </field>
        <field name="productName" form-name="EditCustRequestItem" position="2"><text read-only="true"/></field>
        <field name="quantity" title="${uiLabelMap.CommonQuantity}"><text size="10"/></field>
    </form>
leads to a degradation in functionality. Such a form can be used only with one start form.

With dynamic form building whereby the start-form might be conditionally defined (based on parameter values), the form name required in the lookup fields of the injectable sub-forms should change accordingly.



was (Author: pfm.smits):
Having to have the form name hard coded in the field as in:
{code}
<form name="RequestItemProduct" type="single" skip-start="true" skip-end="true">
        <field name="productId" title="${uiLabelMap.CommonProduct}">
        <lookup target-form-name="LookupProduct" description-field-name="productName" show-description="false"/>
        </field>
        <field name="productName" form-name="EditCustRequestItem" position="2"><text read-only="true"/></field>
        <field name="quantity" title="${uiLabelMap.CommonQuantity}"><text size="10"/></field>
 </form>
{code}
leads to a degradation in functionality.

With dynamic form building whereby the start-form might be conditionally defined (based on parameter values), the form name required in the lookup fields of the injectable sub-forms should change accordingly.


> Lookup fields break when used with a form having skip-start="true"
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-6139
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6139
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: lookup
>             Fix For: 14.12.01, 12.04.06, 13.07.02, Upcoming Branch
>
>
> We neglected this aspect so far. Adding a "form-name" attribute to the field element of the lookup fixes it. 
> The value of "form-name" attribute must be the name of the "parent form", ie the 1st form (the one with skip-end="true") which precedes the current form (which has skip-start="true").
> If you use a related description field (using the "description-field-name" attribute of the lookup element) you need to put the "form-name" attribute in this field element too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)