Return-Path: X-Original-To: apmail-ofbiz-dev-archive@www.apache.org Delivered-To: apmail-ofbiz-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D15617248 for ; Wed, 6 May 2015 17:56:11 +0000 (UTC) Received: (qmail 15527 invoked by uid 500); 6 May 2015 17:56:11 -0000 Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org Received: (qmail 15494 invoked by uid 500); 6 May 2015 17:56:11 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 15470 invoked by uid 99); 6 May 2015 17:56:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 17:56:11 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: message received from 54.164.171.186 which is an MX secondary for dev@ofbiz.apache.org) Received: from [54.164.171.186] (HELO mx1-us-east.apache.org) (54.164.171.186) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 17:56:03 +0000 Received: from smtp23.services.sfr.fr (smtp23.services.sfr.fr [93.17.128.20]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 08EC0428E1 for ; Wed, 6 May 2015 17:55:42 +0000 (UTC) Received: from filter.sfr.fr (localhost [77.130.230.211]) by msfrf2309.sfr.fr (SMTP Server) with ESMTP id 7C9247000178 for ; Wed, 6 May 2015 19:53:36 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=permerror (cannot check policy: Unable to verify) header.from= jacques.le.roux@les7arts.com Received: from [192.168.1.72] (211.230.130.77.rev.sfr.net [77.130.230.211]) by msfrf2309.sfr.fr (SMTP Server) with ESMTP id 3665C7000175 for ; Wed, 6 May 2015 19:53:36 +0200 (CEST) X-SFR-UUID: 20150506175336222.3665C7000175@msfrf2309.sfr.fr Message-ID: <554A5524.60301@les7arts.com> Date: Wed, 06 May 2015 19:53:40 +0200 From: Jacques Le Roux Organization: Les Arts Informatiques User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: dev@ofbiz.apache.org Subject: Re: svn commit: r1675852 - in /ofbiz/trunk/applications/accounting/servicedef: secas.xml secas_invoice.xml References: <20150424132956.ABDB3AC006A@hades.apache.org> <553F33BD.9030804@les7arts.com> In-Reply-To: <553F33BD.9030804@les7arts.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Hi Pranay, Any chances, or is it out of subject? Jacques Le 28/04/2015 09:16, Jacques Le Roux a écrit : > Hi Pranay, > > That's cool, but is it not worth a Jira for releases logs? > > Thanks > > Jacques > > Le 24/04/2015 15:29, pranayp@apache.org a écrit : >> Author: pranayp >> Date: Fri Apr 24 13:29:56 2015 >> New Revision: 1675852 >> >> URL: http://svn.apache.org/r1675852 >> Log: >> Fixed the order in which invoice and payment transactions are created. >> >> Payment transactions were being created prior to invoice transactions, It causes confusion for accountants in real world. >> >> It was a seca execution order which was causing the issue on setInvoiceStatus. Moved the trigger on setInvoiceStatus for >> checkInvoicePaymentApplications and capturePaymentsByInvoice from secas.xml to secas_invoice.xml, so that we do invoice transactions prior to payment. >> >> Modified: >> ofbiz/trunk/applications/accounting/servicedef/secas.xml >> ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml >> >> Modified: ofbiz/trunk/applications/accounting/servicedef/secas.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas.xml?rev=1675852&r1=1675851&r2=1675852&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/accounting/servicedef/secas.xml (original) >> +++ ofbiz/trunk/applications/accounting/servicedef/secas.xml Fri Apr 24 13:29:56 2015 >> @@ -158,13 +158,4 @@ under the License. >> >> >> >> - >> - >> - >> - >> - >> - >> - >> - >> - >> >> >> Modified: ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml?rev=1675852&r1=1675851&r2=1675852&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml (original) >> +++ ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml Fri Apr 24 13:29:56 2015 >> @@ -47,4 +47,12 @@ under the License. >> >> >> + >> + >> + >> + >> + >> + >> + >> + >> >> >> >> >