ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-5947) Move cloneWorkEffortPartyAssignments to workEffortServices.java
Date Thu, 08 Jan 2015 09:07:36 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269018#comment-14269018
] 

Jacques Le Roux commented on OFBIZ-5947:
----------------------------------------

For me it does not need to be changed, until someone really need it, YAGNI ...

But if you are this person please provide a patch and maybe someone will commit it

> Move cloneWorkEffortPartyAssignments to workEffortServices.java
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-5947
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5947
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing, workeffort
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Currently cloneWorkEffortPartyAssignments is in ProductionRunServices.java. But the better
location would be in WorkEffortServices.java.
> That way, when other components want to use that function the dependency would be on
workeffort in stead of manufacturing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message