ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes
Date Wed, 14 Jan 2015 15:00:50 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277007#comment-14277007
] 

Pierre Smits commented on OFBIZ-3764:
-------------------------------------

Should 
{code:xml}
<PartyRelationshipType description="" hasTable="Y" parentTypeId="" partyRelationshipName="Supplier"
partyRelationshipTypeId="SUPPLIER_REL" roleTypeIdValidFrom="" roleTypeIdValidTo=""/>
{code}

not have the following roleTypes set:
 * roleTypeIdValidFrom="INTERNAL_ORGANIZATIO", and
 * roleTypeIdValidTo="SUPPLIER" ?

> Storing supplier relationship sub-class & two related fixes
> -----------------------------------------------------------
>
>                 Key: OFBIZ-3764
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3764
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party, product
>    Affects Versions: Trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>         Attachments: OFBIZ-3764_SupplierRel.patch
>
>
> Despite how much I typed; this is really a very small patch.  :)
> This patch adds a new entity "SupplierRel" which is a sub-class of "PartyRelationship"
(as well as a view-entity for convenience).  It provides a new field "accountNumber" that
can be used to store the long-term account number assigned to the relationship between the
Company and its Supplier.  The life of this account number is longer than any agreement between
the two, so it has been put on this informal relationship.  Moreover, it is possible to have
an informal relationship between a company and a supplier with out an explicit binding agreement
-- this was discussed most recently in this thread:
> http://ofbiz.135035.n4.nabble.com/Storing-supplier-provided-account-number-td2076162.html#a2076162
> ALSO -- this patch fixes two problems that I encountered when attempting to create a
party relationship.
> a) It did not look right to have an empty dropdown for status -- I created the standard
"Created" status under the PARTY_REL_STATUS type so that we show the only applicable status.
 There does not appear to be any specific logic looking for party relationships with a blank
status, so creating ones with this status should not cause any issues.
> b) When creating the PartyRelationship the response in the controller was of type "view-last"
which was a problem because the last controller request was typically the ajax one to "FindPartyName"
which was used as part of the party lookup field in that form.  The net result, was that on
success it would render the PartyName instead of replaying the EditPartyRelationships.  Changed
form "view-last" to "view" to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message