ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Pandey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-5658) checkExistsImage method in ImageManagementServices
Date Tue, 02 Dec 2014 04:53:12 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230980#comment-14230980
] 

Pranay Pandey commented on OFBIZ-5658:
--------------------------------------

Thanks Jacques.

> checkExistsImage method in ImageManagementServices 
> ---------------------------------------------------
>
>                 Key: OFBIZ-5658
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5658
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 13.07
>         Environment: any
>            Reporter: chunlinyao
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Upcoming Branch, 12.04.06, 13.07.02
>
>
> I think indexOf(".") in these code should be lastIndexOf(".")
> public static File checkExistsImage(File file) {
>         if (!file.exists()) {
>             imageCount = 0;
>             imagePath = null;
>             return file;
>         }
>         imageCount++;
>         String filePath = imagePath.substring(0, imagePath.indexOf("."));
>         String type = imagePath.substring(imagePath.indexOf(".") + 1);
>         file = new File(filePath + "(" + imageCount + ")." + type);
>         return checkExistsImage(file);
>     }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message