ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-5658) checkExistsImage method in ImageManagementServices
Date Sun, 22 Jun 2014 12:16:25 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040091#comment-14040091
] 

Jacques Le Roux edited comment on OFBIZ-5658 at 6/22/14 12:15 PM:
------------------------------------------------------------------

Hi Pierre,

Actually Sascha started to work on the integration of Apache JackRabbit after we both finished
the jQuery merge with Ankit Jain and Atul Vani. Then he asked me which other task would be
worth to work on, and I suggested Apache JackRabbit which I had in mind for a while.

He did a great job but unfortunately at this moment I was not available enough to help him
and after he left from Lynx his interest for OFBiz decreased at the point it is now. It's
is a pity, Sascha was really a such driving force! But that's how the world goes :)

And yes, that's one of the reasons having Apache JackRabbit integrated in OFBiz would be great.
Unfortunately like some other main interesting features (SEO branch for instance) I have not
enough continued time to really tackle the challenges alone. Only few cycles here and there
where I try to cope with easier stuff...


was (Author: jacques.le.roux):
Hi Pierre,

Actually Sascha started to work on the integration of Apache JackRabbit after we both finished
the jQuery merge with Ankit Jain and Atul Vani. Then he asked me which other task would be
worth to work on, and I suggested Apache JackRabbit which I had in mind for a while.

He did a great job but unfortunately at this moment I was not available enough to help him
and after the left from Lynx his interest for OFBiz decreased at the point it is now. It's
is a pity, Sascha was really a such driving force! But that's how the world goes :)

And yes, that's one of the reasons having Apache JackRabbit integrated in OFBiz would be great.
Unfortunately like some other main interesting features (SEO branch for instance) I have not
enough continued time to really tackle the challenge alone. Only few cycles here and there
where I try to cope with easier stuff...

> checkExistsImage method in ImageManagementServices 
> ---------------------------------------------------
>
>                 Key: OFBIZ-5658
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5658
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 13.07
>         Environment: any
>            Reporter: chunlinyao
>            Priority: Trivial
>
> I think indexOf(".") in these code should be lastIndexOf(".")
> public static File checkExistsImage(File file) {
>         if (!file.exists()) {
>             imageCount = 0;
>             imagePath = null;
>             return file;
>         }
>         imageCount++;
>         String filePath = imagePath.substring(0, imagePath.indexOf("."));
>         String type = imagePath.substring(imagePath.indexOf(".") + 1);
>         file = new File(filePath + "(" + imageCount + ")." + type);
>         return checkExistsImage(file);
>     }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message