Return-Path: 
 <dev-return-68109-apmail-ofbiz-dev-archive=ofbiz.apache.org@ofbiz.apache.org>
X-Original-To: apmail-ofbiz-dev-archive@www.apache.org
Delivered-To: apmail-ofbiz-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 215A1D3BF
	for <apmail-ofbiz-dev-archive@www.apache.org>;
 Fri,  7 Sep 2012 19:40:09 +0000 (UTC)
Received: (qmail 34526 invoked by uid 500); 7 Sep 2012 19:40:08 -0000
Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org
Received: (qmail 34100 invoked by uid 500); 7 Sep 2012 19:40:07 -0000
Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ofbiz.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ofbiz.apache.org>
List-Post: <mailto:dev@ofbiz.apache.org>
List-Id: <dev.ofbiz.apache.org>
Reply-To: dev@ofbiz.apache.org
Delivered-To: mailing list dev@ofbiz.apache.org
Received: (qmail 33904 invoked by uid 99); 7 Sep 2012 19:40:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2012 19:40:07 +0000
Date: Sat, 8 Sep 2012 06:40:07 +1100 (NCT)
From: "Erwan de FERRIERES (JIRA)" <jira@apache.org>
To: dev@ofbiz.apache.org
Message-ID: <1737982974.51918.1347046807681.JavaMail.jiratomcat@arcas>
In-Reply-To: <799160850.96020.1343143535315.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (OFBIZ-4975) updatePortletSeqDragDrop is not
 working in PortalPage management
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/OFBIZ-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450913#comment-13450913 ] 

Erwan de FERRIERES commented on OFBIZ-4975:
-------------------------------------------

Olivier,
have you some steps to reproduce the error ?

Thanks,
                
> updatePortletSeqDragDrop is not working in PortalPage management
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-4975
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4975
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/myportal
>            Reporter: Olivier Heintz
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>         Attachments: OFBIZ-4975.patch
>
>
> When you try to change Portlet order in a PortalPage, most of the time it does'nt work.
> To show why, I start to change in minilang service, calculate attribute by a set
> {code}
>              <iterate entry="modifyPp" list="modifyPpList">
>                  <if-empty field="modifyPp.sequenceNum">
>                      <set field="modifyPp.sequenceNum" value="newSequenceNo"/>
>                      <else>
> -                        <calculate field="modifyPp.sequenceNum" type="Long">
> -                            <calcop operator="add" field="newSequenceNo">
> -                                <calcop operator="get" field="increase"/>
> -                            </calcop>
> -                        </calculate>
> -                        <calculate field="increase" type="Long">
> -                            <calcop operator="add" field="increase">
> -                                <calcop operator="get" field="increase"/>
> -                            </calcop>
> -                        </calculate>
> +                      <set field="modifyPp.sequenceNum" from="newSequenceNo+increase" />
> +                      <set field="increase" from="increase+increase" />
>                      </else>
>                  </if-empty>
>                  <store-value value-field="modifyPp"/>
>              </iterate>
> {code}
> the error was to not use a second field, the correct code should be
> {code}
>              <iterate entry="modifyPp" list="modifyPpList">
>                  <if-empty field="modifyPp.sequenceNum">
>                      <set field="modifyPp.sequenceNum" value="newSequenceNo"/>
>                      <else>
>                       <if-empty field="newValue">
>                           <set field="newValue" from="increase"/>
>                       </if-empty>
>                       <set field="modifyPp.sequenceNum" from="newSequenceNo+newValue" />
>                       <set field="newValue" from="newValue+increase"/>
>                      </else>
>                  </if-empty>
>                  <store-value value-field="modifyPp"/>
>              </iterate>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira