ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olivier Heintz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-4975) updatePortletSeqDragDrop is not working in PortalPage management
Date Mon, 10 Sep 2012 10:20:07 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451864#comment-13451864
] 

Olivier Heintz commented on OFBIZ-4975:
---------------------------------------

Erwan,
not step to reproduce but a detail example.
If you have in a column portlet 
- A seqNum 1
- B seqNum 2
- C seqNum 3
- D seqNum 4
- E seqNum 5
- F seqNum 6
if a new portlet Y is introduced  between A and B the result was
- A seqNum 1
- Y seqNum 2
- B seqNum 3
- C seqNum 4
- D seqNum 6
- E seqNum 10
- F seqNum 18
the correct result should be
- A seqNum 1
- Y seqNum 2
- B seqNum 3
- C seqNum 4
- D seqNum 5
- E seqNum 6
- F seqNum 7

So, the start of Jira description is not correct, most of time, for the user it work's even
if sequenceNum are "strange" .

Hoping it's more clear.


                
> updatePortletSeqDragDrop is not working in PortalPage management
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-4975
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4975
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/myportal
>            Reporter: Olivier Heintz
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>         Attachments: OFBIZ-4975.patch
>
>
> When you try to change Portlet order in a PortalPage, most of the time it does'nt work.
> To show why, I start to change in minilang service, calculate attribute by a set
> {code}
>              <iterate entry="modifyPp" list="modifyPpList">
>                  <if-empty field="modifyPp.sequenceNum">
>                      <set field="modifyPp.sequenceNum" value="newSequenceNo"/>
>                      <else>
> -                        <calculate field="modifyPp.sequenceNum" type="Long">
> -                            <calcop operator="add" field="newSequenceNo">
> -                                <calcop operator="get" field="increase"/>
> -                            </calcop>
> -                        </calculate>
> -                        <calculate field="increase" type="Long">
> -                            <calcop operator="add" field="increase">
> -                                <calcop operator="get" field="increase"/>
> -                            </calcop>
> -                        </calculate>
> +                      <set field="modifyPp.sequenceNum" from="newSequenceNo+increase"
/>
> +                      <set field="increase" from="increase+increase" />
>                      </else>
>                  </if-empty>
>                  <store-value value-field="modifyPp"/>
>              </iterate>
> {code}
> the error was to not use a second field, the correct code should be
> {code}
>              <iterate entry="modifyPp" list="modifyPpList">
>                  <if-empty field="modifyPp.sequenceNum">
>                      <set field="modifyPp.sequenceNum" value="newSequenceNo"/>
>                      <else>
>                       <if-empty field="newValue">
>                           <set field="newValue" from="increase"/>
>                       </if-empty>
>                       <set field="modifyPp.sequenceNum" from="newSequenceNo+newValue"
/>
>                       <set field="newValue" from="newValue+increase"/>
>                      </else>
>                  </if-empty>
>                  <store-value value-field="modifyPp"/>
>              </iterate>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message