Return-Path: X-Original-To: apmail-ofbiz-dev-archive@www.apache.org Delivered-To: apmail-ofbiz-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9941F9718 for ; Sat, 5 May 2012 08:26:20 +0000 (UTC) Received: (qmail 66395 invoked by uid 500); 5 May 2012 08:26:20 -0000 Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org Received: (qmail 66353 invoked by uid 500); 5 May 2012 08:26:20 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 66342 invoked by uid 99); 5 May 2012 08:26:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 May 2012 08:26:20 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [108.163.220.50] (HELO delivery.mailspamprotection.com) (108.163.220.50) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 May 2012 08:26:11 +0000 Received: from ns1.siteground309.com ([184.154.233.20] helo=serv01.siteground309.com) by se8.mailspamprotection.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1SQaJH-0007KD-75 for dev@ofbiz.apache.org; Sat, 05 May 2012 03:25:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandglass-software.com; s=dkim; h=Message-ID:Date:From: MIME-Version:To:Subject:References:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=oJi8I8YC8v1pDewysj8IwHwZhsCLQ4+aKB Z74j9Dwr8=; b=MlTcWTtiJeQ3zFj+7vkZ7SvRzaTKBkJsAiLrmF7aRRiqfTY1tD QrggjxuYwsihXSaJwqeYxCpXvScDEzbW6J0kwiudmzGwnE/4Mn2p2cbXpPrDDf/s WYzHdKNMU6oXy89UGv6CKOtXFcx6Y3U/5As6V3lCtp/+I1BFFyq1gZKIk= Received: from [86.173.96.130] (port=4583 helo=[192.168.1.64]) by serv01.siteground309.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1SQaJH-0008Rl-CD for dev@ofbiz.apache.org; Sat, 05 May 2012 03:25:47 -0500 Message-ID: <4FA4E40B.6040409@sandglass-software.com> Date: Sat, 05 May 2012 09:25:47 +0100 From: Adrian Crum Organization: Sandglass Software User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: dev@ofbiz.apache.org Subject: Re: svn commit: r1334336 - /ofbiz/trunk/framework/catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java References: <20120505075935.42EFE2388860@eris.apache.org> <99682ABB-D5CD-4871-B6D4-AA0D29B946C0@hotwaxmedia.com> In-Reply-To: <99682ABB-D5CD-4871-B6D4-AA0D29B946C0@hotwaxmedia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground309.com X-AntiAbuse: Original Domain - ofbiz.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - sandglass-software.com X-Filter-ID: XtLePq6GTMn8G68F0EmQvYAgAWPFUAzp+Jo6fAgZIhdAY1BaLfwb0I4SZzVEHfhbITx1A9a4ShBP XO22k6PcG8FKa2lm3sFCi50KJv/sR+n4IzSAwmslZTyo/VDMvvBnwpXcoJTg0z3fXIRnNZPTPpX9 oK7M9OWrTxt4b30OKiD0VOxtJ9xK+CrTR2IVviL9hZb3tizCb+4O22pAzuqQbWUOh0CktS69fvOu y4BsuwNssqXBcXzhU3ovgimzObkVNoMtui+IG4d1OJgtC0S5ACG7X+t1TW39Ja77LGPpOwCu/FWe t1tSwvgVFtYY58Kt91xo/VkZ1yhbRBGHYqBem254oFU0kPk2S0GIwB0TFML0VOxtJ9xK+CrTR2IV viL99QoIKP7GM6i6GLki7We0jJWdd0E3aO6dn9c3K01C2PRVllMHrEsVONjtZZ+yS1Co4KKOD2TX I3D5K+Qhr/l7JS7/+fOTvqVqTiiM4NskccRll9HsEliOjoZlIqyAeu+W21vgvydv4zD3f3yAzcLb pQbqK9fECNhq06bEEOp57ZoHmFDqewO9xyOqCYO8P1aHvje9ON2QojxVj5aDdeYG+6xRzsLJkQYJ LGxsQNfY1iA= X-Originating-IP: 184.154.233.20 X-SpamExperts-Domain: siteground309.com X-SpamExperts-Username: 184.154.233.20 Authentication-Results: mailspamprotection.com; auth=pass () smtp.auth=184.154.233.20 X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: CRM114 (6.1402) X-Recommended-Action: accept On 5/5/2012 9:19 AM, Jacopo Cappellato wrote: > On May 5, 2012, at 9:59 AM, jleroux@apache.org wrote: > >> + boolean appIsDistributable = webXmlDoc.getElementsByTagName("distributable").getLength()> 0 ? true : false; > (a trivial note) this can be simplified with: > > boolean appIsDistributable = webXmlDoc.getElementsByTagName("distributable").getLength()> 0; > > Jacopo Also, the multiple catch blocks can be reduced to a singe catch (Exception e). -Adrian