ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Crum <adrian.c...@sandglass-software.com>
Subject Re: svn commit: r1334336 - /ofbiz/trunk/framework/catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java
Date Sat, 05 May 2012 08:25:47 GMT
On 5/5/2012 9:19 AM, Jacopo Cappellato wrote:
> On May 5, 2012, at 9:59 AM, jleroux@apache.org wrote:
>
>> +        boolean appIsDistributable = webXmlDoc.getElementsByTagName("distributable").getLength()>
 0 ? true : false;
> (a trivial note) this can be simplified with:
>
> boolean appIsDistributable = webXmlDoc.getElementsByTagName("distributable").getLength()>
 0;
>
> Jacopo

Also, the multiple catch blocks can be reduced to a singe catch 
(Exception e).

-Adrian


Mime
View raw message