ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Malin <malin.nico...@librenberry.net>
Subject Re: svn commit: r1308650 - /ofbiz/trunk/tools/rc.ofbiz.for.ubuntu
Date Tue, 03 Apr 2012 07:12:26 GMT
Hi hans,

Just some suggests

> @@ -32,14 +32,18 @@ OFBIZDIR="ofbiz"
>
>   # Start OFBiz
>   start() {
> +    if [ "$USER" = "" ]; then
> +        echo "Mounting data disk at boottime here"
> +#        mount /dev/sdg /data
> +    fi
It's not a specific server configuration ?

>       running
>       if [ "$OFBIZ_PROCS" = "" ]; then
>           echo "Ofbiz is already running..."
>           return 0
>       fi
>       if [ "$USER" = "$OFBIZUSER" ]; then
> -        echo "starting standard ~/$OFBIZDIR/startofbiz.sh"
> -        cd ~/$OFBIZDIR
> +        echo "starting standard /home/$OFBIZUSER/$OFBIZDIR/startofbiz.sh"
> +        cd /home/$OFBIZUSER/$OFBIZDIR
I propose to replace "/home/$OFBIZUSER/$OFBIZDIR" by
OFBIZ_LOCATION = "/home/$OFBIZUSER/$OFBIZDIR"
and use like :
cd $OFBIZ_LOCATION

It's will be easier to change the ofbiz location especially if you have 
various ofbiz on same server ;)

Nicolas

-- 
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/


Mime
View raw message