ofbiz-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux" <jacques.le.r...@les7arts.com>
Subject Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
Date Wed, 12 Jan 2011 21:21:53 GMT
That's great guys, but it would be better if you could keep your comments in the OFBIZ-4092
Really easier later when looking back to have things centralized somewhere (I saw Adrian tried
to create a new thread...)

Thanks

Jacques

Ryan Foster wrote:
> Bruno,
>
> I'll see your 2 cents, and raise you a dollar.  I agree, the naming of an element should
never dictate how it looks or behaves;
> that is what properties are for.  You are opening up a can of worms with me when you
start down that path, so careful what you
> wish for.  Buttons aren't the only offenders when it comes to that, the problem starts
with the main decorator.  The layout of
> the backend and the front end center around the fact that we have column layouts with
classNames of .left, .right, and .center.
> What if I don't want .left on the left anymore?...
>
> Ryan L. Foster
> 801.671.0769
> contact@ryanlfoster.com
> ryanlfoster.com
>
> On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote:
>
>> In addition, when deprecating or selecting styles to be used we should
>> better use style names that describe what the button IS in the screen and
>> not HOW it should appear.
>>
>> So style names like
>> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
>> .button-style-1, .button-style-2,
>>
>> should not be used.
>>
>> Style names like:
>> .buttontext,
>> .loginButton,
>> .button,
>> input[type="reset"],
>> input[type="submit"],
>> input[type="button"]
>>
>> are OK.
>> In this way the theme can make a button larger or smaller than another
>> button according to its function.
>>
>> My two cents.
>> -Bruno
>>
>> 2011/1/12 Ryan Foster (JIRA) <jira@apache.org>
>>
>>>
>>>   [
>>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>>
>>> Ryan Foster commented on OFBIZ-4092:
>>> ------------------------------------
>>>
>>> I tried deleting deprecated styles and letting things break when I created
>>> the BizznessTime theme... mostly just pissed people off.  :)
>>>
>>>> Update The Flat Grey Visual Theme
>>>> ---------------------------------
>>>>
>>>>                Key: OFBIZ-4092
>>>>                URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>>            Project: OFBiz
>>>>         Issue Type: Improvement
>>>>         Components: framework
>>>>   Affects Versions: SVN trunk
>>>>           Reporter: Adrian Crum
>>>>           Assignee: Adrian Crum
>>>>           Priority: Minor
>>>>        Attachments: ac_flatgrey.patch, ac_images.zip,
>>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>>> timeSheet.png
>>>>
>>>>
>>>> Update the Flat Grey visual theme. Design objectives:
>>>> 1. Floating, flexible layout - screen can be resized.
>>>> 2. Sight impaired accessible - users can change font size in their
>>> browser.
>>>> 3. Supports RTL layout.
>>>> 4. Does not require JavaScript. JavaScript can be used to add
>>> embellishments, but the theme can't depend on it.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online. 



Mime
View raw message