Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Message-ID: <24126011.27211286469874487.JavaMail.jira@thor>
Date: Thu, 7 Oct 2010 12:44:34 -0400 (EDT)
From: "Jacques Le Roux (JIRA)" <jira@apache.org>
To: dev@ofbiz.apache.org
Subject: [jira] Reopened: (OFBIZ-3969) sendMailFrom Screen don't need to
 load uiLabels
In-Reply-To: <23334794.494461285925676078.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/OFBIZ-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-3969:
------------------------------------


BTW you asked :D

> sendMailFrom Screen don't need to load uiLabels
> -----------------------------------------------
>
>                 Key: OFBIZ-3969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3969
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3969_OrderServices.patch
>
>
> Hi, 
> i noticed an issues in the sendOrderNotificationScreen method. There is no need of loading uiLabels in the method, because the labels will be loaded in the screen (which will be used for the email). 
> The point is, when someone (for whatever reason) don't add English uiLabels and the service try to access the default English labels the an exception will be thrown :-). This can be simply avoided.
> Cheers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.