Return-Path: Delivered-To: apmail-ofbiz-dev-archive@www.apache.org Received: (qmail 28679 invoked from network); 21 Jul 2010 22:52:39 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Jul 2010 22:52:39 -0000 Received: (qmail 83645 invoked by uid 500); 21 Jul 2010 22:52:39 -0000 Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org Received: (qmail 83608 invoked by uid 500); 21 Jul 2010 22:52:38 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 83600 invoked by uid 99); 21 Jul 2010 22:52:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jul 2010 22:52:38 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [70.103.162.5] (HELO newmail.brainfood.com) (70.103.162.5) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jul 2010 22:52:30 +0000 Received: from localhost (localhost [127.0.0.1]) by newmail.brainfood.com (Postfix) with ESMTP id B8683F900C for ; Wed, 21 Jul 2010 17:52:06 -0500 (CDT) X-Virus-Scanned: amavisd-new at X-Spam-Score: 1.231 X-Spam-Level: * Received: from newmail.brainfood.com ([127.0.0.1]) by localhost (newmail.brainfood.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P7VQmFFoB9WD for ; Wed, 21 Jul 2010 17:52:02 -0500 (CDT) Received: from [192.168.3.49] (70-103-162-249.brainfood.com [70.103.162.249]) by newmail.brainfood.com (Postfix) with ESMTP id 9F33AF900B for ; Wed, 21 Jul 2010 17:52:02 -0500 (CDT) Message-ID: <4C477A11.3000405@brainfood.com> Date: Wed, 21 Jul 2010 17:52:01 -0500 From: Adam Heath User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: dev@ofbiz.apache.org Subject: Re: svn commit: r966203 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java References: <20100721121408.5925623889B9@eris.apache.org>

<9B35BA23-A675-4AE9-9970-B81E0A7BD291@hotwaxmedia.com> In-Reply-To: <9B35BA23-A675-4AE9-9970-B81E0A7BD291@hotwaxmedia.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Flag: NO X-Old-Spam-Status: No, score=1.231 tagged_above=-10 required=6.6 tests=[BAYES_50=0.001, DNS_FROM_OPENWHOIS=1.13, RDNS_DYNAMIC=0.1] Scott Gray wrote: > If it is just a drop down then it should probably just not have an initial value. If all time fields that have no value suddenly start defaulting to 00:00, then how can one have a field where the time value is not required? 00:00 is not the same thing as null. This change should be backed out. > > Regards > Scott > > On 22/07/2010, at 10:09 AM, Jacques Le Roux wrote: > >> Yes sure, just that it needs a little effort and is not how things are commonly handled in OFBiz. >> I'd think now is a better default because who care about 00:00? But yes it's subjective and I agree not a big deal... >> >> This question also because I'm not quite sure what is the origin for the time 00:00 or now? (and how long is now, a bit of philo/humour never hurt ;o) >> >> Jacques >> >> Scott Gray wrote: >>> As long as it doesn't break the default-value attribute I don't care, you can easily get the old behavior by using >> default-value="${nowTimestamp}"/> >>> >>> Regards >>> Scott >>> >>> HotWax Media >>> http://www.hotwaxmedia.com >>> >>> On 22/07/2010, at 1:04 AM, Jacques Le Roux wrote: >>> >>>> Everybody agree about that? >>>> >>>> Jacques >>>> >>>>> Author: erwan >>>>> Date: Wed Jul 21 12:14:08 2010 >>>>> New Revision: 966203 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=966203&view=rev >>>>> Log: >>>>> if a time-dropdown has no value then 00:00 is displayed instead of the current time >>>>> >>>>> Modified: >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java >>>>> >>>>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java >>>>> URL: >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java?rev=966203&r1=966202&r2=966203&view=diff >>>>> ============================================================================== --- >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java (original) +++ >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java Wed Jul 21 12:14:08 2010 @@ -571,7 +571,7 @@ >>>>> public class MacroFormRenderer implement >>>>> >>>>> // if we have an input method of time-dropdown, then render two >>>>> // dropdowns >>>>> - if ("time-dropdown".equals(dateTimeField.getInputMethod())) { >>>>> + if ("time-dropdown".equals(dateTimeField.getInputMethod()) && UtilValidate.isNotEmpty(value)) { >>>>> className = modelFormField.getWidgetStyle(); >>>>> classString = (className != null ? className : ""); >>>>> isTwelveHour = "12".equals(dateTimeField.getClock()); >> >