Return-Path: Delivered-To: apmail-ofbiz-dev-archive@www.apache.org Received: (qmail 46646 invoked from network); 1 Apr 2008 05:14:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Apr 2008 05:14:44 -0000 Received: (qmail 72376 invoked by uid 500); 1 Apr 2008 05:14:43 -0000 Delivered-To: apmail-ofbiz-dev-archive@ofbiz.apache.org Received: (qmail 72365 invoked by uid 500); 1 Apr 2008 05:14:43 -0000 Mailing-List: contact dev-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list dev@ofbiz.apache.org Received: (qmail 72356 invoked by uid 99); 1 Apr 2008 05:14:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Mar 2008 22:14:43 -0700 X-ASF-Spam-Status: No, hits=3.8 required=10.0 tests=HTML_MESSAGE,MIME_QP_LONG_LINE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [63.246.23.145] (HELO mail.hotwaxmedia.com) (63.246.23.145) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2008 05:13:59 +0000 Received: (qmail 14397 invoked by uid 89); 1 Apr 2008 05:14:11 -0000 Received: by simscan 1.1.0 ppid: 14384, pid: 14392, t: 8.7028s scanners: regex: 1.1.0 clamav: 0.92.1/m:45/d:5777 spam: 3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on hwm03.managed.contegix.com X-Spam-Level: Received: from unknown (HELO ?192.168.1.52?) (mridul@hotwaxmedia.com@122.168.28.59) by mail.hotwaxmedia.com with ESMTPA; 1 Apr 2008 05:14:02 -0000 Message-Id: <8636AE39-47DE-46F8-AEF9-52286AA384FD@hotwaxmedia.com> From: Mridul Pathak To: dev@ofbiz.apache.org In-Reply-To: <1207023232.6763.76.camel@Antweb-hans> Content-Type: multipart/alternative; boundary=Apple-Mail-5--1061112207 Mime-Version: 1.0 (Apple Message framework v912) Subject: Re: svn commit: r642949 - in /ofbiz/trunk/applications/product: config/ProductUiLabels.xml entitydef/entitymodel.xml webapp/catalog/WEB-INF/controller.xml webapp/catalog/product/ProductForms.xml widget/catalog/ProductScreens.xml Date: Tue, 1 Apr 2008 10:43:57 +0530 References: <20080331101317.326CE1A9832@eris.apache.org> <1206958748.9841.7.camel@Antweb-hans> <1207023232.6763.76.camel@Antweb-hans> X-Mailer: Apple Mail (2.912) X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-3.0 required=7.0 tests=ALL_TRUSTED,AWL,BAYES_00, HTML_MESSAGE,MIME_QP_LONG_LINE autolearn=no version=3.2.4 --Apple-Mail-5--1061112207 Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Hi All, For this I did suggested a way when this topic was discussed on =20 the user mailing list. The way I suggested was that, we can add the =20 field with name virtualVariantMethod either in Product of Product =20 store and for this field we can define the enumerations like =20 VARIANT_TREE and FEATURE_TREE. If it is defined on Product than it =20 will give us a way to select one of the two methods for that product. =20= On the other hand, if this field is defined for a ProductStore, than =20 the selected method will apply to all the products that comes under =20 that ProductStore. This way it won't seem odd like it is when using Old and New =20 keywords. Does it seems a suitable approach? Regards, Mridul Pathak On Apr 1, 2008, at 9:43 AM, Hans Bakker wrote: > Hi David, > > sure, i have investigated first to improve the current method. That is > not possible because the dependencies are stored with the available > variants. If a variant is not available the feature cannot be =20 > selected. > > This means however that always all variants need to be checked for all > options. If you have 6 feature types with each of them 6 options the > total number of possibilities is about 6*6*6*6*6*6 is about 46000 =20 > which > need to be retrieved and kept in the html form..... > > The basic difference between the old method and the new method is that > the dependencies are now stored at the feature level and that in the > above case only 6*6 features need to be retrieved. Incompatibilities > will be checked after the selection. It will now also be possible to > check dependencies which is not possible in the old method. > > On the other hand both methods are compatible and one can switch from > the old method to the new method, add the dependencies at the feature > level and ready you are....One can also go back afterwards. > > So to answer your question, i think with not so many variants the old > method is better and with many variants the new one is. Integration is > pretty difficult because the data retrieved and the html used is > completely different although the display is very similar > > Hope this answers your question? > > Regards, > Hans > > > > On Mon, 2008-03-31 at 20:57 -0600, David E Jones wrote: >> My first thought is that a field on the Product entity is not the =20 >> best >> way to set this up... aside from the possibility that maybe we don't >> want an "old" way and a "new" way, maybe we just want one way. >> >> Has any effort been put into combining the two methods, or are they >> totally incompatible? If someone with old data used the new code =20 >> would >> it work as it used to, as is expected? >> >> -David >> >> >> On Mar 31, 2008, at 4:19 AM, Hans Bakker wrote: >>> By Accident the new field on the product has also slipped in to >>> indicate >>> the new virtual/variant implementation >>> >>> Please let me know if this is acceptable, or we should do it >>> differently. >>> >>> Regards, >>> Hans >>> >>> >>> On Mon, 2008-03-31 at 10:13 +0000, hansbak@apache.org wrote: >>>> Author: hansbak >>>> Date: Mon Mar 31 03:13:05 2008 >>>> New Revision: 642949 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=3D642949&view=3Drev >>>> Log: >>>> add feature interactions to a product >>>> >>>> Modified: >>>> ofbiz/trunk/applications/product/config/ProductUiLabels.xml >>>> ofbiz/trunk/applications/product/entitydef/entitymodel.xml >>>> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ >>>> controller.xml >>>> ofbiz/trunk/applications/product/webapp/catalog/product/ >>>> ProductForms.xml >>>> ofbiz/trunk/applications/product/widget/catalog/=20 >>>> ProductScreens.xml >>>> >>>> Modified: ofbiz/trunk/applications/product/config/=20 >>>> ProductUiLabels.xml >>>> URL: = http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/Produ= ctUiLabels.xml?rev=3D642949&r1=3D642948&r2=3D642949&view=3Ddiff >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D=20 >>>> =3D=20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- ofbiz/trunk/applications/product/config/ProductUiLabels.xml >>>> (original) >>>> +++ ofbiz/trunk/applications/product/config/ProductUiLabels.xml Mon >>>> Mar 31 03:13:05 2008 >>>> @@ -4082,7 +4082,16 @@ >>>> =C3=90=CB=9C=C3=90=C2=B7=C3=90=C2=BC=C3= =90=C2=B5=C3=90=C2=BD=C3=90=C2=B8=C3=91=E2=80=9A=C3=91=C5=92 =20 >>>> =C3=90=C2=BA=C3=90 >>>> =C2=B0=C3=91=E2=80=9A=C3=90=C2=B5=C3=90=C2=B3=C3=90=C2=BE=C3=91=E2=82= =AC=C3=90=C2=B8=C3=90=C2=B8 =C3=90=C2=BE=C3=91=C2=81=C3=90=C2=BE=C3=90 >>>> =C2=B1=C3=90=C2=B5=C3=90=C2=BD=C3=90=C2=BD=C3=90=C2=BE=C3=91=C2=81=C3= =91=E2=80=9A=C3=90=C2=B5=C3=90=C2=B9 >>>> =C3=A0=C2=B9=C2=81=C3=A0=C2=B8=C2=81=C3= =A0=C2=B9 >>>> =E2=80=B0=C3=A0=C2=B9=E2=80=9E=C3=A0=C2=B8=E2=80=9A=C3=A0=C2=B8=E2=80= =BA=C3=A0=C2=B8=C2=A3=C3=A0=C2=B8=C2=B0=C3=A0=C2=B9=E2=82=AC=C3=A0=C2=B8 = =C3=A0=C2=B8=E2=80=94 >>>> =C3=A0=C2=B8=C2=81=C3=A0=C2=B8=C2=B2=C3=A0=C2=B8=C2=A3=C3=A0=C2=B8=E2= =80=94=C3=A0=C2=B8=C2=B3=C3=A0=C2=B8=E2=80=A1=C3=A0=C2=B8=C2=B2=C3=A0=C2=B8= =E2=84=A2 >>>> =C3=A7=C2=BC=E2=80=93=C3=A8=C2=BE=E2=80= =98=C3=A7=E2=80=B0=C2=B9=C3=A5=C2=BE=C2=81=C3=A7 >>>> =C2=B1=C2=BB=C3=A5=C5=BE=E2=80=B9 >>>> - >>>> + >>>> + >>>> + Add Feature Interaction >>>> + >>>> + >>>> + List Feature Interactions >>>> + >>>> + >>>> + Edit Product Feature Interactions>>> value> >>>> + >>>> >>>> Add Feature InterAction >>>> >>>> @@ -11466,6 +11475,9 @@ >>>> =C3=90=C2=9D=C3=90=C2=BE=C3=90=C2=B2=C3= =91=E2=80=B9=C3=90=C2=B9 =C3=90=C2=BF=C3=90=C2=BE=C3=90 >>>> =C2=B4=C3=90=C2=BF=C3=90=C2=B8=C3=91=C2=81=C3=90=C2=BD=C3=90=C2=BE=C3= =90=C2=B9 =C3=91=E2=82=AC=C3=90=C2=B5=C3=91=C2=81=C3=91=C6=92=C3=91=E2=82=AC= =C3=91=C2=81 >>>> =C3=A0=C2=B9=C2=81=C3=A0=C2=B8=C2=AB=C3= =A0=C2=B8 >>>> =C2=A5=C3=A0=C2=B9=CB=86=C3=A0=C2=B8=E2=80=A1=C3=A0=C2=B8=E2=80=9A=C3= =A0=C2=B9=E2=80=B0=C3=A0=C2=B8 =C3=A0=C2=B8=C2=A1=C3=A0=C2=B8=C2=B9=C3=A0=C2= =B8=20 >>>> =C2=A5=C3=A0=C2=B8=C2=81=C3=A0=C2=B8=C2=B2=C3=A0=C2=B8 >>>> =C2=A3=C3=A0=C2=B8=C2=AA=C3=A0=C2=B8=C2=B1=C3=A0=C2=B9=CB=86=C3=A0=C2= =B8=E2=80=A1=C3=A0=C2=B8=E2=80=B9=C3=A0=C2=B8=C2=B7=C3=A0=C2=B9=E2=80=B0=C3= =A0=C2=B8 >>>> =C3=A0=C2=B9=C6=92=C3=A0=C2=B8=C2=AB=C3=A0=C2=B8=C2=A1=C3=A0=C2=B9=CB= =86 >>>> =C3=A6=E2=80=93=C2=B0=C3=A5=C2=BB=C2=BA= =C3=A8=C2=AE=C2=A2=C3=A9=CB=9C=E2=80=A6 >>>> =C3=A8=C2=B5=E2=80=9E=C3=A6=C2=BA=C2=90 >>>> + >>>> + >>>> + New Method >>>> >>>> >>>> New Virtual Product >>>> >>>> Modified: ofbiz/trunk/applications/product/entitydef/=20 >>>> entitymodel.xml >>>> URL: = http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/entitydef/en= titymodel.xml?rev=3D642949&r1=3D642948&r2=3D642949&view=3Ddiff >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D=20 >>>> =3D=20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- ofbiz/trunk/applications/product/entitydef/entitymodel.xml >>>> (original) >>>> +++ ofbiz/trunk/applications/product/entitydef/entitymodel.xml Mon >>>> Mar 31 03:13:05 2008 >>>> @@ -2387,6 +2387,7 @@ >>>> >>>> >>>> >>>> + >>> type=3D"indicator">If this field is set to 'Y', the = new >>>> feature variant selection method will be used, other values will >>>> use the old method >>>> >>>> >>>> >>>> >>>> Modified: ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ >>>> controller.xml >>>> URL: = http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catal= og/WEB-INF/controller.xml?rev=3D642949&r1=3D642948&r2=3D642949&view=3Ddiff= >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D=20 >>>> =3D=20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ >>>> controller.xml (original) >>>> +++ ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ >>>> controller.xml Mon Mar 31 03:13:05 2008 >>>> @@ -1174,6 +1174,18 @@ >>>> >>> value=3D"EditFeatureInterActions"/> >>>> >>> value=3D"EditFeatureInterAction"/> >>>> >>>> + >>>> + >>>> + >>> invoke=3D"createProductFeatureIactn"/> >>>> + >>> value=3D"EditProductFeatures"/> >>>> + >>> value=3D"EditProductFeatures"/> >>>> + >>>> + >>>> + >>>> + >>> invoke=3D"removeProductFeatureIactn"/> >>>> + >>> value=3D"EditProductFeatures"/> >>>> + >>> value=3D"EditProductFeatures"/> >>>> + >>>> >>>> >>>> >>> invoke=3D"createProductFeatureType"/> >>>> >>>> Modified: ofbiz/trunk/applications/product/webapp/catalog/product/ >>>> ProductForms.xml >>>> URL: = http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catal= og/product/ProductForms.xml?rev=3D642949&r1=3D642948&r2=3D642949&view=3Ddi= ff >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D=20 >>>> =3D=20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- ofbiz/trunk/applications/product/webapp/catalog/product/ >>>> ProductForms.xml (original) >>>> +++ ofbiz/trunk/applications/product/webapp/catalog/product/ >>>> ProductForms.xml Mon Mar 31 03:13:05 2008 >>>> @@ -41,6 +41,9 @@ >>>> >>> {uiLabelMap.ProductVariantProduct}"> >>>> >>>> >>>> + >>> title=3D"$ >>>> {uiLabelMap.ProductNewVirtualVariantMethod}"> >>>> + >>>> + >>>> >>> {uiLabelMap.ProductProductType}"> >>>> >>>> >>> description=3D"${description}"> >>>> @@ -1219,7 +1222,50 @@ >>>> >>>> >>> {uiLabelMap.CommonUpdate}"> >>>> >>>> - >>>> +
>>> name=3D"featureInteractions" type=3D"list" >>>> + odd-row-style=3D"alternate-row" = default-table-style=3D"basic- >>>> table"> >>>> + >>>> + >>> description=3D"${description}"> >>>> + >>> productFeatureId=3D${productFeatureId}" description=3D"[$ >>>> {productFeatureId}]"/> >>>> + >>>> + >>>> + >>>> + >>> description=3D"${description}" key-field-name=3D"productFeatureId"> >>>> + >>> productFeatureId=3D${productFeatureIdTo}" description=3D"[$ >>>> {productFeatureIdTo}]"/> >>>> + >>>> + >>>> + >>> entity-name=3D"ProductFeatureIactnType"/> >>>> + >>>> + >>> {uiLabelMap.CommonDelete}" widget-style=3D"buttontext"> >>>> + >>> productFeatureId=3D >>>> ${productFeatureId}&productFeatureIdTo=3D$ >>>> {productFeatureIdTo}&productId=3D${productId}" description=3D"$ >>>> {uiLabelMap.CommonDelete}"/> >>>> + >>>> +
>>>> +
>>> target=3D"AddProductFeatureIactn" title=3D"" default-map- >>>> name=3D"productFeatureIactn" >>>> + header-row-style=3D"header-row" = default-table-style=3D"basic- >>>> table"> >>>> + >>>> + >>>> + >>>> + >>> {productFeatureId}]" entity-name=3D"ProductFeature"> >>>> + >>>> + >>>> + >>>> + >>>> + >>>> + >>>> + >>> {productFeatureId}]" entity-name=3D"ProductFeature" key-field- >>>> name=3D"productFeatureId"> >>>> + >>>> + >>>> + >>>> + >>>> + >>>> + >>>> + >>> entity-name=3D"ProductFeatureIactnType"> >>>> + >>>> + >>>> + >>>> + >>>> + >>> widget-style=3D"smallSubmit">= >>>> +
>>>>
>>> target=3D"createProductFeatureApplAttr" title=3D"" >>>> header-row-style=3D"header-row" default-table-style=3D"basic- >>>> table"> >>>> >>> name=3D"createProductFeatureApplAttr" /> >>>> >>>> Modified: ofbiz/trunk/applications/product/widget/catalog/ >>>> ProductScreens.xml >>>> URL: = http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catal= og/ProductScreens.xml?rev=3D642949&r1=3D642948&r2=3D642949&view=3Ddiff >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D >>>> =3D=20 >>>> =3D=20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- ofbiz/trunk/applications/product/widget/catalog/ >>>> ProductScreens.xml (original) >>>> +++ ofbiz/trunk/applications/product/widget/catalog/ >>>> ProductScreens.xml Mon Mar 31 03:13:05 2008 >>>> @@ -1067,10 +1067,13 @@ >>>> >>>> >>> value=3D"EditProductFeatures"/> >>>> >>> value=3D"ProductFeatures"/> >>>> - >>>> + >>>> >>> field=3D"parameters.productId"/> >>>> >>> name=3D"product"/> >>>>