From commits-return-38510-apmail-ofbiz-commits-archive=ofbiz.apache.org@ofbiz.apache.org Wed Nov 14 17:31:29 2018 Return-Path: X-Original-To: apmail-ofbiz-commits-archive@www.apache.org Delivered-To: apmail-ofbiz-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC69C18347 for ; Wed, 14 Nov 2018 17:31:28 +0000 (UTC) Received: (qmail 13974 invoked by uid 500); 14 Nov 2018 17:31:28 -0000 Delivered-To: apmail-ofbiz-commits-archive@ofbiz.apache.org Received: (qmail 13946 invoked by uid 500); 14 Nov 2018 17:31:28 -0000 Mailing-List: contact commits-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list commits@ofbiz.apache.org Received: (qmail 13937 invoked by uid 99); 14 Nov 2018 17:31:28 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Nov 2018 17:31:28 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 1CA483A0F6C for ; Wed, 14 Nov 2018 17:31:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1846594 - /ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy Date: Wed, 14 Nov 2018 17:31:28 -0000 To: commits@ofbiz.apache.org From: jleroux@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20181114173128.1CA483A0F6C@svn01-us-west.apache.org> Author: jleroux Date: Wed Nov 14 17:31:27 2018 New Revision: 1846594 URL: http://svn.apache.org/viewvc?rev=1846594&view=rev Log: Fixed: Manufacturing BOM search returning duplicate entries in search results (OFBIZ-10648) Bill of Materials search returning duplicate entries in search results. Test Steps: 1. Login to Manufacturing application. 2. Navigate to Bill of Materials tab. 3. Observe the issue in Search results. Expected Result: Unique products should be displayed on Bill of Materials search results. Actual Result: Bill of Materials search returning duplicate entries in search results. The distinct constraint is missing in FindProductBom.groovy find query. Thanks: Aditya Barve Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy?rev=1846594&r1=1846593&r2=1846594&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy (original) +++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/bom/FindProductBom.groovy Wed Nov 14 17:31:27 2018 @@ -41,7 +41,7 @@ if (parameters.productAssocTypeId) { bomListIterator = select("productId", "internalName", "productAssocTypeId") .from("ProductAndAssoc") .where(condList) - .orderBy("productId", "productAssocTypeId") + .orderBy("productId", "productAssocTypeId").distinct() .cursorScrollInsensitive() .cache(true) .queryIterator()