ofbiz-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jler...@apache.org
Subject svn commit: r1846214 - /ofbiz/ofbiz-framework/trunk/applications/content/widget/forum/ForumForms.xml
Date Fri, 09 Nov 2018 08:11:46 GMT
Author: jleroux
Date: Fri Nov  9 08:11:46 2018
New Revision: 1846214

URL: http://svn.apache.org/viewvc?rev=1846214&view=rev
Fixed: Content - Able to add empty Forum Group

Steps to Regenerate issue:
 # Login to demo-trunk or demo-stable instance with details:
URL - [https://demo-trunk.ofbiz.apache.org/content/control/findForumGroups] 
admin/ ofbiz  OR
URl - [https://demo-stable.ofbiz.apache.org/content/control/createForumGroup]
admin/ ofbiz
 # Go to Content > Forum and try to create new forum group.
 # do not enter Forum Group Name and Description.
 # Click on the Submit button.

Actual - System allowed the user to enter an empty forum group. 
This issue is occurring at demo-trunk and demo-stable instance. 

Expected - Empty Forum group should not be added. If the user tries to do this
s/he should not be allowed and proper validation error message should display.

Thanks: Sanjay Yadav


Modified: ofbiz/ofbiz-framework/trunk/applications/content/widget/forum/ForumForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/content/widget/forum/ForumForms.xml?rev=1846214&r1=1846213&r2=1846214&view=diff
--- ofbiz/ofbiz-framework/trunk/applications/content/widget/forum/ForumForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/content/widget/forum/ForumForms.xml Fri Nov 
9 08:11:46 2018
@@ -33,7 +33,7 @@ under the License.
     <form name="AddForumGroup" type="single" target="createForumGroup" title="" default-map-name="forumGroup"
         header-row-style="header-row" default-table-style="basic-table">
-        <field name="forumGroupName" parameter-name="contentName"><text/></field>
+        <field name="forumGroupName" parameter-name="contentName" required-field="true"><text/></field>
         <field name="forumGroupDescription" parameter-name="description"><text/></field>
         <field name="contentTypeId"><hidden value="FORUM_ROOT"/></field>
         <field name="submitButton" widget-style="smallSubmit"><submit button-type="button"/></field>

View raw message