ofbiz-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jler...@apache.org
Subject svn commit: r1789864 - in /ofbiz/branches/release16.11: ./ applications/content/widget/content/DataResourceForms.xml
Date Sun, 02 Apr 2017 09:27:42 GMT
Author: jleroux
Date: Sun Apr  2 09:27:42 2017
New Revision: 1789864

URL: http://svn.apache.org/viewvc?rev=1789864&view=rev
Log:
"Applied fix from trunk framework for revision: 1789863  " 
------------------------------------------------------------------------
r1789863 | jleroux | 2017-04-02 11:26:36 +0200 (dim. 02 avr. 2017) | 33 lignes

Fixed: Sort Links in Lookup for Data Resource Id causes unwanted behaviour on 
Find Content page
(OFBIZ-9280)

How to reproduce :
1. Log in the Content component
2. Go to the Content tab. https://localhost:8443/content/control/findContent
3. In the search form, open the lookup of the field ' Data Resource Id '
4. Click on any of the table header links to sort the table. Results will be
 displayed on a new unstyled window closing the Lookup dialog.


Problem:
Problem:
1. Lookup dialog for dataResourceId uses "ListLookupDataResource" form to list 
Data Resource records.
2. "ListLookupDataResource" form extends "ListDataResource" form for all the 
fields.
3. Sort-field is set to true in "ListDataResource" form for all the fields.
4. Sort-field adds <a> hyperlink to "LookupResource" .
5. When clicked <a> link it moves to a new page and doesn't renders the response
 in the Lookup dialog.
Solution:
First of all it is a lookup to select DataResourceId so as the pattern followed 
in other lookups in OFBiz it should not have any sort-fields.To set it false, 
it should be overridden. If all fields needs to be overridden it is better not 
to extend "ListDataResource" form and add these fields right away.
Apart from that added 'widget-style="smallSubmit"' to dataResourceId according 
to the uniform pattern followed.

jleroux: I added the header-row-style="header-row-2" style

Thanks: Aditya Sharma
------------------------------------------------------------------------


Modified:
    ofbiz/branches/release16.11/   (props changed)
    ofbiz/branches/release16.11/applications/content/widget/content/DataResourceForms.xml

Propchange: ofbiz/branches/release16.11/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Apr  2 09:27:42 2017
@@ -10,5 +10,5 @@
 /ofbiz/branches/json-integration-refactoring:1634077-1635900
 /ofbiz/branches/multitenant20100310:921280-927264
 /ofbiz/branches/release13.07:1547657
-/ofbiz/ofbiz-framework/trunk:1783202,1783388,1784549,1784558,1784708,1785882,1785925,1786079,1786214,1786525,1787047,1787133,1787176,1787535,1787906-1787911,1787949,1789665
+/ofbiz/ofbiz-framework/trunk:1783202,1783388,1784549,1784558,1784708,1785882,1785925,1786079,1786214,1786525,1787047,1787133,1787176,1787535,1787906-1787911,1787949,1789665,1789863
 /ofbiz/trunk:1770481,1770490,1770540,1771440,1771448,1771516,1771935,1772346,1772880,1774772,1775441,1779724,1780659,1781109,1781125,1781979,1782498,1782520

Modified: ofbiz/branches/release16.11/applications/content/widget/content/DataResourceForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release16.11/applications/content/widget/content/DataResourceForms.xml?rev=1789864&r1=1789863&r2=1789864&view=diff
==============================================================================
--- ofbiz/branches/release16.11/applications/content/widget/content/DataResourceForms.xml
(original)
+++ ofbiz/branches/release16.11/applications/content/widget/content/DataResourceForms.xml
Sun Apr  2 09:27:42 2017
@@ -127,10 +127,10 @@ under the License.
                 <sort-field name="lastModifiedByUserLogin"/>
             </field-group>
         </sort-order>
-
     </form>
-    <form name="ListLookupDataResource" extends="ListDataResource" list-name="listIt"
type="list" paginate-target="LookupDataResource"
-        odd-row-style="alternate-row" default-table-style="basic-table hover-bar">
+
+    <form name="ListLookupDataResource" list-name="listIt" type="list" paginate-target="LookupDataResource"
+        odd-row-style="alternate-row" header-row-style="header-row-2" default-table-style="basic-table
hover-bar">
         <actions>
             <service service-name="performFind" result-map-list="listIt">
                 <field-map field-name="inputFields" from-field="parameters"/>
@@ -140,10 +140,16 @@ under the License.
                 <field-map field-name="viewSize" from-field="viewSize"/>
             </service>
         </actions>
-        <field name="dataResourceId" title="${uiLabelMap.ContentDataResourceId}">
+        <field name="dataResourceId" title="${uiLabelMap.ContentDataResourceId}" widget-style="smallSubmit">
             <hyperlink description="${dataResourceId}" target="javascript:set_value('${dataResourceId}')"
also-hidden="false" target-type="plain"/>
         </field>
         <field name="dataResourceName"><display/></field>
+        <field name="dataResourceTypeId"><display-entity entity-name="DataResourceType"></display-entity></field>
+        <field name="mimeTypeId"><display-entity entity-name="MimeType"></display-entity></field>
+        <field name="statusId"><display-entity entity-name="StatusItem"></display-entity></field>
+        <field name="localeString"><display-entity entity-name="CountryCode" description="${countryName}[${countryCode}]"
key-field-name="countryCode"></display-entity></field>
+        <field name="createdByUserLogin"><display-entity also-hidden="false" entity-name="PartyNameView"
key-field-name="partyId" description="${groupName}${firstName} ${lastName}"/></field>
+        <field name="dataCategoryId"><display-entity entity-name="DataCategory"
description="${categoryName}[${dataCategoryId}]"></display-entity></field>
     </form>
     <form name="MruLookupDataResource" default-entity-name="DataResource" list-name="mruList"
target="" title="" type="list" default-widget-style="display"
         odd-row-style="alternate-row" default-table-style="basic-table hover-bar">



Mime
View raw message