Return-Path: Delivered-To: apmail-ofbiz-commits-archive@www.apache.org Received: (qmail 94276 invoked from network); 3 Mar 2010 22:12:34 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Mar 2010 22:12:34 -0000 Received: (qmail 20734 invoked by uid 500); 3 Mar 2010 22:12:26 -0000 Delivered-To: apmail-ofbiz-commits-archive@ofbiz.apache.org Received: (qmail 20704 invoked by uid 500); 3 Mar 2010 22:12:26 -0000 Mailing-List: contact commits-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list commits@ofbiz.apache.org Received: (qmail 20693 invoked by uid 99); 3 Mar 2010 22:12:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Mar 2010 22:12:25 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Mar 2010 22:12:24 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8E319238897A; Wed, 3 Mar 2010 22:12:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r918726 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java Date: Wed, 03 Mar 2010 22:12:03 -0000 To: commits@ofbiz.apache.org From: doogie@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100303221203.8E319238897A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: doogie Date: Wed Mar 3 22:12:03 2010 New Revision: 918726 URL: http://svn.apache.org/viewvc?rev=918726&view=rev Log: Make all the internal variables private and/or final. Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java?rev=918726&r1=918725&r2=918726&view=diff ============================================================================== --- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java (original) +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java Wed Mar 3 22:12:03 2010 @@ -35,9 +35,9 @@ public static final String module = JNDIConfigUtil.class.getName(); public static final String JNDI_CONFIG_XML_FILENAME = "jndiservers.xml"; - protected static Map jndiServerInfos = FastMap.newInstance(); + private static final Map jndiServerInfos = FastMap.newInstance(); - protected static Element getXmlRootElement() throws GenericConfigException { + private static Element getXmlRootElement() throws GenericConfigException { try { return ResourceLoader.getXmlRootElement(JNDIConfigUtil.JNDI_CONFIG_XML_FILENAME); } catch (GenericConfigException e) { @@ -45,7 +45,7 @@ } } - protected static Document getXmlDocument() throws GenericConfigException { + private static Document getXmlDocument() throws GenericConfigException { try { return ResourceLoader.getXmlDocument(JNDIConfigUtil.JNDI_CONFIG_XML_FILENAME); } catch (GenericConfigException e) {