Return-Path: Delivered-To: apmail-ofbiz-commits-archive@www.apache.org Received: (qmail 33612 invoked from network); 27 Feb 2009 21:30:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Feb 2009 21:30:23 -0000 Received: (qmail 65286 invoked by uid 500); 27 Feb 2009 21:30:22 -0000 Delivered-To: apmail-ofbiz-commits-archive@ofbiz.apache.org Received: (qmail 65262 invoked by uid 500); 27 Feb 2009 21:30:22 -0000 Mailing-List: contact commits-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list commits@ofbiz.apache.org Received: (qmail 65244 invoked by uid 99); 27 Feb 2009 21:30:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2009 13:30:22 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [67.221.226.157] (HELO zimbra.hotwaxmedia.com) (67.221.226.157) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2009 21:30:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.hotwaxmedia.com (Postfix) with ESMTP id BFDA0EB809A; Fri, 27 Feb 2009 15:29:49 -0600 (CST) X-Virus-Scanned: amavisd-new at X-Spam-Score: -2.499 X-Spam-Level: Received: from zimbra.hotwaxmedia.com ([127.0.0.1]) by localhost (zimbra.hotwaxmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KrEC-OUBnLDq; Fri, 27 Feb 2009 15:29:45 -0600 (CST) Received: from [192.168.4.81] (unknown [12.110.50.18]) by zimbra.hotwaxmedia.com (Postfix) with ESMTP id 8CA01EB8096; Fri, 27 Feb 2009 15:29:44 -0600 (CST) Cc: commits@ofbiz.apache.org Message-Id: <3FCACFC2-D1EF-493E-BF20-F260199218AE@apache.org> From: David E Jones To: dev@ofbiz.apache.org In-Reply-To: <20090227202654.BFEB523889B2@eris.apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: svn commit: r748683 - in /ofbiz/trunk/applications: content/entitydef/entitymodel.xml order/entitydef/entitymodel.xml party/entitydef/entitymodel.xml Date: Fri, 27 Feb 2009 14:29:43 -0700 References: <20090227202654.BFEB523889B2@eris.apache.org> X-Mailer: Apple Mail (2.930.3) X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Flag: NO X-Old-Spam-Status: No, score=-2.499 tagged_above=-10 required=6.2 tests=[BAYES_00=-2.599, RDNS_NONE=0.1] Are the entity field labels actually used for all of these entities? Generally this feature ONLY makes sense for things that are part of seed data, things that may be entered by users should use other patterns for i18n. The suspect entities that are included here include: - Content (has the alternate locale associated content pattern for i18n) - PartyClassificationGroup The rest look fine, and are populated by seed data (ie data that is maintained with code). -David On Feb 27, 2009, at 1:26 PM, mrisaliti@apache.org wrote: > Author: mrisaliti > Date: Fri Feb 27 20:26:54 2009 > New Revision: 748683 > > URL: http://svn.apache.org/viewvc?rev=748683&view=rev > Log: > Some missing default-resource-name for entity labels. > > Modified: > ofbiz/trunk/applications/content/entitydef/entitymodel.xml > ofbiz/trunk/applications/order/entitydef/entitymodel.xml > ofbiz/trunk/applications/party/entitydef/entitymodel.xml > > Modified: ofbiz/trunk/applications/content/entitydef/entitymodel.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/content/entitydef/entitymodel.xml > (original) > +++ ofbiz/trunk/applications/content/entitydef/entitymodel.xml Fri > Feb 27 20:26:54 2009 > @@ -150,6 +150,7 @@ > > package-name="org.ofbiz.content.content" > + default-resource-name="ContentEntityLabels" > title="Content Entity"> > > > @@ -412,6 +413,7 @@ > > package-name="org.ofbiz.content.content" > + default-resource-name="ContentEntityLabels" > title="Content Association Predicate Entity"> > > > @@ -731,6 +733,7 @@ > > package-name="org.ofbiz.content.data" > + default-resource-name="ContentEntityLabels" > title="Character Set Entity"> > > > @@ -1093,6 +1096,7 @@ > > package-name="org.ofbiz.content.document" > + default-resource-name="ContentEntityLabels" > title="Document Type Entity"> > > > > Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml > (original) > +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Fri Feb > 27 20:26:54 2009 > @@ -253,6 +253,7 @@ > > package-name="org.ofbiz.order.order" > + default-resource-name="OrderEntityLabels" > title="Order Blacklist Type Entity"> > > > @@ -912,6 +913,7 @@ > > package-name="org.ofbiz.order.order" > + default-resource-name="OrderEntityLabels" > title="Order Item Type Entity"> > > > @@ -1276,6 +1278,7 @@ > > package-name="org.ofbiz.order.order" > + default-resource-name="OrderEntityLabels" > title="Order Content Type Entity"> > > > > Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml > (original) > +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Fri Feb > 27 20:26:54 2009 > @@ -1800,6 +1800,7 @@ > > package-name="org.ofbiz.party.party" > + default-resource-name="PartyEntityLabels" > title="Party Classification Group Entity"> > > > >