ode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From va...@apache.org
Subject [4/4] git commit: minor clean up.
Date Thu, 15 Aug 2013 22:52:05 GMT
minor clean up.


Project: http://git-wip-us.apache.org/repos/asf/ode-jacob/repo
Commit: http://git-wip-us.apache.org/repos/asf/ode-jacob/commit/b9dcd896
Tree: http://git-wip-us.apache.org/repos/asf/ode-jacob/tree/b9dcd896
Diff: http://git-wip-us.apache.org/repos/asf/ode-jacob/diff/b9dcd896

Branch: refs/heads/master
Commit: b9dcd896336de34e889788bcb3785a87915daa4d
Parents: fdaf1f2
Author: Tammo van Lessen <vanto@apache.org>
Authored: Fri Aug 16 00:51:13 2013 +0200
Committer: Tammo van Lessen <vanto@apache.org>
Committed: Fri Aug 16 00:51:13 2013 +0200

----------------------------------------------------------------------
 src/main/java/org/apache/ode/jacob/Jacob.java        | 2 +-
 src/main/java/org/apache/ode/jacob/JacobThread.java  | 2 +-
 src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java | 5 +++--
 3 files changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ode-jacob/blob/b9dcd896/src/main/java/org/apache/ode/jacob/Jacob.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/ode/jacob/Jacob.java b/src/main/java/org/apache/ode/jacob/Jacob.java
index b636994..12fa1d4 100644
--- a/src/main/java/org/apache/ode/jacob/Jacob.java
+++ b/src/main/java/org/apache/ode/jacob/Jacob.java
@@ -41,7 +41,7 @@ public class Jacob {
     public static <T extends Channel> T newChannel(Class<T> channelType, String
description)
         throws IllegalArgumentException
     {
-        return (T) JacobVPU.activeJacobThread().newChannel(channelType, null, description);
+        return (T) JacobVPU.activeJacobThread().newChannel(channelType, description);
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/ode-jacob/blob/b9dcd896/src/main/java/org/apache/ode/jacob/JacobThread.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/ode/jacob/JacobThread.java b/src/main/java/org/apache/ode/jacob/JacobThread.java
index 1d95c13..5d2f9ae 100644
--- a/src/main/java/org/apache/ode/jacob/JacobThread.java
+++ b/src/main/java/org/apache/ode/jacob/JacobThread.java
@@ -101,7 +101,7 @@ public interface JacobThread {
     /**
      * Create a new channel.
      */
-    public Channel newChannel(Class<?> channelType, String creator, String description);
+    public Channel newChannel(Class<?> channelType, String description);
 
     /**
      * <p>

http://git-wip-us.apache.org/repos/asf/ode-jacob/blob/b9dcd896/src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java b/src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java
index ae4db3a..7061f96 100644
--- a/src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java
+++ b/src/main/java/org/apache/ode/jacob/vpu/JacobVPU.java
@@ -264,7 +264,7 @@ public final class JacobVPU {
                     throw new IllegalStateException(
                         "Channel method '" + method + "' must only return void or an implementation
of " + Channel.class.getName());
                 }
-                replyChannel = newChannel(method.getReturnType(), "", "Reply Channel");
+                replyChannel = newChannel(method.getReturnType(), "Reply Channel");
                 replyCommChannel = (CommChannel) ChannelFactory.getBackend((Channel)replyChannel);
             }
             
@@ -287,7 +287,7 @@ public final class JacobVPU {
             _executionQueue.add(grp);
         }
 
-        public Channel newChannel(Class<?> channelType, String creator, String description)
{
+        public Channel newChannel(Class<?> channelType, String description) {
             CommChannel chnl = new CommChannel(channelType);
             chnl.setDescription(description);
             _executionQueue.add(chnl);
@@ -491,6 +491,7 @@ public final class JacobVPU {
                 }
                 
                 if (replyTo != null) {
+                    //XXX: All replys have the same Synch.ret() action 
                     sendMessage(ClassUtil.createMessage(replyTo, ClassUtil.SYNCH_RET_METHOD_ACTION,
null, null));
                 }
 			} finally {


Mime
View raw message