nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3632: [bp-3614]arch/risc-v: Fix stack alignment according to calling convention
Date Thu, 29 Apr 2021 18:19:33 GMT

gustavonihei commented on a change in pull request #3632:
URL: https://github.com/apache/incubator-nuttx/pull/3632#discussion_r623285622



##########
File path: arch/risc-v/src/litex/litex_head.S
##########
@@ -188,17 +188,17 @@ exception_common:
  *  Name: g_intstackalloc and g_intstackbase
  ************************************************************************************/
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 3
+#if CONFIG_ARCH_INTERRUPTSTACK > 15
   .bss
-  .align  4
+  .balign  16
   .global g_intstackalloc
   .global g_intstackbase
   .type   g_intstackalloc, object
   .type   g_intstackbase, object
 g_intstackalloc:
-  .skip  ((CONFIG_ARCH_INTERRUPTSTACK & ~3))
+  .skip  ((CONFIG_ARCH_INTERRUPTSTACK & ~15))
 g_intstackbase:
   .skip  4
   .size  g_intstackbase, 4
-  .size  g_intstackalloc, (CONFIG_ARCH_INTERRUPTSTACK & ~3)
+  .size  g_intstackalloc, (CONFIG_ARCH_INTERRUPTSTACK + 8) & ~15)

Review comment:
       Actually, you applied the `+ 8)` to the wrong place.
   It should have beed added to line 199, to the `.skip` command.
   The build should pass after this one is fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message