From commits-return-10098-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat May 23 17:24:20 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 54300180634 for ; Sat, 23 May 2020 19:24:20 +0200 (CEST) Received: (qmail 5781 invoked by uid 500); 23 May 2020 17:24:19 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 5771 invoked by uid 99); 23 May 2020 17:24:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 May 2020 17:24:19 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_xiaoxiang781216_commented_on_a_?= =?utf-8?q?change_in_pull_request_=231109=3A_libs/libnx/nxfonts/=2Egitignore?= =?utf-8?q?=3A_Ignore_auto-generated_file=2E?= Message-ID: <159025465944.19379.1161061611760777723.asfpy@gitbox.apache.org> Date: Sat, 23 May 2020 17:24:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: xiaoxiang781216 commented on a change in pull request #1109: URL: https://github.com/apache/incubator-nuttx/pull/1109#discussion_r429563424 ########## File path: libs/libnx/nxfonts/.gitignore ########## @@ -1,2 +1,3 @@ nxfonts_convert_*bpp.c nxfonts_bitmaps_*.c +nxfonts_tom-thumb-4x6.c Review comment: Don't need since the generated name change to nxfonts_bitmaps_tom-thumb-4x6.c by commit: ``` commit 23389215bb09b2997c2e29a39b635339c202bf3e Author: liuhaitao Date: Tue Apr 28 14:18:22 2020 +0800 libnx/nxfonts: change the generated file nxfonts_tom-thumb-4x6.c to nxfonts_bitmap_tom-thumb-4x6.c Align the generated files name, so make distclean could also remove all nxfonts_bitmaps_*.c files, no need to add one more extra DELFILE for nxfonts_tom-thumb-4x6.c. Signed-off-by: liuhaitao ``` But forget to update .gitignore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org