From commits-return-9623-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Fri May 15 02:57:40 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2FA78180621 for ; Fri, 15 May 2020 04:57:40 +0200 (CEST) Received: (qmail 14980 invoked by uid 500); 15 May 2020 02:57:39 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 14971 invoked by uid 99); 15 May 2020 02:57:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2020 02:57:39 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_masayuki2009_commented_on_a_cha?= =?utf-8?q?nge_in_pull_request_=231052=3A_drivers=3A_wireless=3A_Apply_max_p?= =?utf-8?q?ayload_size_to_gs2200m=2Ec?= Message-ID: <158951145955.19379.17234641239042893325.asfpy@gitbox.apache.org> Date: Fri, 15 May 2020 02:57:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: masayuki2009 commented on a change in pull request #1052: URL: https://github.com/apache/incubator-nuttx/pull/1052#discussion_r425538667 ########## File path: drivers/wireless/gs2200m.c ########## @@ -85,6 +85,7 @@ #define NRESPMSG (16 + 2) #define MAX_PKT_LEN 1500 +#define MAX_PAYLOAD (MAX_PKT_LEN - 36) Review comment: Hello @patacongo Thanks fot the comments. Actually, It it not an IP header nor TCP header. It's just a GS2200M command header + guard size. Anyway I'll define the value later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org