From commits-return-8915-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Tue May 5 13:44:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 78AB6180626 for ; Tue, 5 May 2020 15:44:55 +0200 (CEST) Received: (qmail 50465 invoked by uid 500); 5 May 2020 13:44:54 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 50455 invoked by uid 99); 5 May 2020 13:44:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2020 13:44:54 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_patacongo_commented_on_a_change?= =?utf-8?q?_in_pull_request_=23965=3A_fs=3A_Remove_all_LIBC=5FIOCTL=5FVARIAD?= =?utf-8?q?IC_related_stuff?= Message-ID: <158868629485.26397.8244931248038783708.asfpy@gitbox.apache.org> Date: Tue, 05 May 2020 13:44:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: patacongo commented on a change in pull request #965: URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420120217 ########## File path: syscall/syscall_stublookup.c ########## @@ -189,13 +189,9 @@ uintptr_t STUB_nx_vsyslog(int nbr, uintptr_t parm1, uintptr_t parm2, */ uintptr_t STUB_close(int nbr, uintptr_t parm1); -#ifdef CONFIG_LIBC_IOCTL_VARIADIC -uintptr_t STUB_fs_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2, - uintptr_t parm3); -#else uintptr_t STUB_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2, - uintptr_t parm3); -#endif + uintptr_t parm3, uintptr_t parm4, uintptr_t parm5, + uintptr_t parm6); Review comment: This is terrible. I am very strongly opposed to this and will not merge this PR with this kind of code. Very bad. Please follow the model of syslog, vsyslog, and nx_vsyslog. That will work. This is bad. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org