From commits-return-8914-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Tue May 5 13:43:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 76242180626 for ; Tue, 5 May 2020 15:43:54 +0200 (CEST) Received: (qmail 48807 invoked by uid 500); 5 May 2020 13:43:54 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 48796 invoked by uid 99); 5 May 2020 13:43:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2020 13:43:53 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_patacongo_commented_on_a_change?= =?utf-8?q?_in_pull_request_=23965=3A_fs=3A_Remove_all_LIBC=5FIOCTL=5FVARIAD?= =?utf-8?q?IC_related_stuff?= Message-ID: <158868623389.26397.8423927350876095012.asfpy@gitbox.apache.org> Date: Tue, 05 May 2020 13:43:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: patacongo commented on a change in pull request #965: URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420119455 ########## File path: syscall/syscall.csv ########## @@ -42,7 +41,7 @@ "if_indextoname","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","FAR char *","unsigned int","FAR char *" "if_nametoindex","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","unsigned int","FAR const char *" "insmod","nuttx/module.h","defined(CONFIG_MODULE)","FAR void *","FAR const char *","FAR const char *" -"ioctl","sys/ioctl.h","!defined(CONFIG_LIBC_IOCTL_VARIADIC)","int","int","int","unsigned long" +"ioctl","sys/ioctl.h","","int","int","int","..." Review comment: ... will not work in system calls. You must follow the patter of vsyslog: "nx_vsyslog","nuttx/syslog/syslog.h","","int","int","FAR const IPTR char*","FAR va_list*" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org