From commits-return-8807-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Mon May 4 14:23:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A446F180608 for ; Mon, 4 May 2020 16:23:06 +0200 (CEST) Received: (qmail 72513 invoked by uid 500); 4 May 2020 14:23:06 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 72504 invoked by uid 99); 4 May 2020 14:23:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 14:23:06 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_patacongo_edited_a_comment_on_p?= =?utf-8?q?ull_request_=23904=3A_x86=5F64=3A_Resolve_linking_and_compiler_wa?= =?utf-8?q?rning_issues?= Message-ID: <158860218607.26397.15267334999313427601.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 14:23:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: patacongo edited a comment on pull request #904: URL: https://github.com/apache/incubator-nuttx/pull/904#issuecomment-623494001 @btashton I get confused by PR's like this where there are a lot of comments, but no resolved discussions. Things are just left up in the are. Should this be merged? YES or NO? It looks good to me and I see it contains a few minor bugfixes that need to come in in any event. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org