From commits-return-8727-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sun May 3 17:39:35 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 119B3180621 for ; Sun, 3 May 2020 19:39:34 +0200 (CEST) Received: (qmail 42593 invoked by uid 500); 3 May 2020 17:39:34 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 42584 invoked by uid 99); 3 May 2020 17:39:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 May 2020 17:39:34 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_acassis_commented_on_pull_reque?= =?utf-8?q?st_=23960=3A_Improvements_for_STM32_ADC?= Message-ID: <158852757430.26397.8920840779882131400.asfpy@gitbox.apache.org> Date: Sun, 03 May 2020 17:39:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: acassis commented on pull request #960: URL: https://github.com/apache/incubator-nuttx/pull/960#issuecomment-623150210 Hi Mateusz, It is reporting some a compilation error: chip/stm32_adc.c:656:20: error: initialization of 'void (*)(struct stm32_adc_dev_s *, uint32_t)' {aka 'void (*)(struct stm32_adc_dev_s *, unsigned int)'} from incompatible pointer type 'int (*)(struct stm32_dev_s *, uint32_t)' {aka 'int (*)(struct stm32_dev_s *, unsigned int)'} [-Werror=incompatible-pointer-types] 656 | .jextcfg_set = adc_jextcfg_set, | ^~~~~~~~~~~~~~~ chip/stm32_adc.c:656:20: note: (near initialization for 'g_adc_llops.jextcfg_set') chip/stm32_adc.c: In function 'adc_llops_setup': chip/stm32_adc.c:4140:1: error: no return statement in function returning non-void [-Werror=return-type] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org